Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autocomplete to subject + people + places #6050

Closed
Tracked by #6434
bicolino34 opened this issue Jan 14, 2022 · 8 comments · Fixed by #6888
Closed
Tracked by #6434

Add autocomplete to subject + people + places #6050

bicolino34 opened this issue Jan 14, 2022 · 8 comments · Fixed by #6888
Labels
Lead: @jimchamp Issues overseen by Jim (Front-end Lead, BookNotes) [managed] Needs: Community Discussion This issue is to be brought up in the next community call. [managed] Needs: Help Issues, typically substantial ones, that need a dedicated developer to take them on. [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]

Comments

@bicolino34
Copy link
Collaborator

I would like to have list of prompts when typing info for books. Preferably, with number of usage of this certain subject.

Example from Russian fan fiction site ficbook.net (search for users).
image

@bicolino34 bicolino34 added Needs: Lead Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] labels Jan 14, 2022
@jimchamp jimchamp changed the title List of prompts when typing Places/People/Subjects Add autocomplete to subject + people + places Jan 24, 2022
@jimchamp jimchamp added Lead: @jimchamp Issues overseen by Jim (Front-end Lead, BookNotes) [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed] and removed Needs: Lead Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] labels Jan 24, 2022
@tuminzee
Copy link
Collaborator

I would like to work on this issue

@BrittanyBunk
Copy link
Contributor

BrittanyBunk commented Jan 25, 2022

This actually, as I discussed in #6074 was also discussed at the same meeting - we all talked about which keywords should be pulled out of books.

We thought about how the most common words can be pulled out, but we realize that those would not be representative of the book itself, as you'd get issues like having the word 'the' or 'a', prepositions, etc. popping up. Then we thought about having the unique words come up, but those might just be for one sentence and doesn't represent the book at all.

Then maybe the most common unique word can be used, but that might just be referenced without it being about the book at all.

I actually suggested having the keywords from google books be brought into the Open Library. I actually feel like I already wrote this out somewhere, but I can't find it

@tuminzee maybe what I suggested will help you out.

Google books used to show all the frequent, unique words in a book - but they don't anymore, so it's not possible to port them over. Maybe that's why we didn't go through with that.

@BrittanyBunk
Copy link
Contributor

this is related to #4027 , because the issue is keywords aren't the same as what the book's about itself.

@BrittanyBunk
Copy link
Contributor

I think I found the reason for this problem here: #584

@tuminzee
Copy link
Collaborator

tuminzee commented Feb 4, 2022

Sorry @BrittanyBunk it took me some time to reply to this, but I really like the early references which you have tagged here

@tuminzee tuminzee added the Needs: Response Issues which require feedback from lead label Feb 4, 2022
@mekarpeles mekarpeles added Needs: Community Discussion This issue is to be brought up in the next community call. [managed] Needs: Help Issues, typically substantial ones, that need a dedicated developer to take them on. [managed] and removed Needs: Response Issues which require feedback from lead labels Feb 7, 2022
@mekarpeles
Copy link
Member

@tuminzee if you still would like to work on this issue, would you like to propose a small technical plan + design and bring to an upcoming community call for discussion?

@tuminzee
Copy link
Collaborator

tuminzee commented Feb 8, 2022

@mekarpeles yes I will do that :)

@tuminzee
Copy link
Collaborator

sorry @mekarpeles I wouldn't be able to finish it right now.
I will un-assign myself from the task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Lead: @jimchamp Issues overseen by Jim (Front-end Lead, BookNotes) [managed] Needs: Community Discussion This issue is to be brought up in the next community call. [managed] Needs: Help Issues, typically substantial ones, that need a dedicated developer to take them on. [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants