Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ebook facet numbers not matching results #6598

Open
cdrini opened this issue May 27, 2022 · 1 comment
Open

Ebook facet numbers not matching results #6598

cdrini opened this issue May 27, 2022 · 1 comment
Labels
Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Module: Search Page(s) Issues pertaining to the Search page UI Priority: 4 An issue, but should be worked on when no other pressing work can be done. [managed] Theme: Search Issues related to search UI and backend. [managed] Type: Bug Something isn't working. [managed]
Milestone
The Icebox

Comments

@cdrini
Copy link
Collaborator

cdrini commented May 27, 2022

https://openlibrary.org/search?q=Carolyne+Aarsen+Wrangling+the+Cowboy%27s+Heart&mode=ebooks&has_fulltext=true indicates one book but does not display it in the results

https://openlibrary.org/search?mode=ebooks&q=Carolyne+Aarsen+Wrangling+the+Cowboy%27s+Heart indicates that the 1 item is a printdisabled only book.

i'd suggest it should be displayed in ebook results so i'd consider it a bug.

Evidence / Screenshot (if possible)

Relevant url?

Steps to Reproduce

  1. Go to https://openlibrary.org/search?q=Carolyne+Aarsen+Wrangling+the+Cowboy%27s+Heart&mode=ebooks&has_fulltext=true
  • Actual: No books appear!
  • Expected: 1 book to appears, as the "1 hit" text suggests"

Details

  • Logged in (Y/N)? Y
  • Browser type/version? FF 100
  • Operating system? Win10
  • Environment (prod/dev/local)? prod

Proposal & Constraints

Related files

Stakeholders

@JeffKaplan
@cdrini cdrini added Type: Bug Something isn't working. [managed] Theme: Search Issues related to search UI and backend. [managed] Priority: 2 Important, as time permits. [managed] Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Module: Search Page(s) Issues pertaining to the Search page UI labels May 27, 2022
@cdrini cdrini added this to the Next (proposed) milestone May 27, 2022
@cdrini
Copy link
Collaborator Author

cdrini commented May 27, 2022

This is happening because the ebooks filter is currently applied after the solr search in the python. Once we have #6564 in solr, we should use that to back the ebooks facet.

As a shorter solution we might also be able to just remove the python filter here for users with printdisabled access?

@cdrini cdrini added Priority: 4 An issue, but should be worked on when no other pressing work can be done. [managed] and removed Priority: 2 Important, as time permits. [managed] labels Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Module: Search Page(s) Issues pertaining to the Search page UI Priority: 4 An issue, but should be worked on when no other pressing work can be done. [managed] Theme: Search Issues related to search UI and backend. [managed] Type: Bug Something isn't working. [managed]
Projects
None yet
Milestone
The Icebox
Development

No branches or pull requests
1 participant
@cdrini