Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge UI should not allow merge if records have changed in the mean time #6675

Open
cdrini opened this issue Jun 20, 2022 · 1 comment
Open

Merge UI should not allow merge if records have changed in the mean time #6675

cdrini opened this issue Jun 20, 2022 · 1 comment
Assignees
@cdrini
Labels
Affects: Librarians Issues related to features that librarians particularly need. [managed] Lead: @mheiman Priority: 3 Issues that we can consider at our leisure. [managed] Type: Bug Something isn't working. [managed]
Milestone
The Icebox

Comments

@cdrini
Copy link
Collaborator

cdrini commented Jun 20, 2022 •
edited by mekarpeles

When a super librarian clicks on the merge button the underlying code will re-fetch all the works/docs and if there are any edits (since) the UI will inform them to refresh

Evidence / Screenshot (if possible)

Relevant url?

Steps to Reproduce

  1. Go to ...
  2. Do ...
  • Actual:
  • Expected:

Details

  • Logged in (Y/N)?
  • Browser type/version?
  • Operating system?
  • Environment (prod/dev/local)? prod

Proposal & Constraints

Related files

Stakeholders
@cdrini cdrini added Type: Bug Something isn't working. [managed] Priority: 1 Do this week, receiving emails, time sensitive, . [managed] Needs: Detail Submitter needs to provide more detail for this issue to be assessed (see comments). [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Needs: Lead labels Jun 20, 2022
@cdrini cdrini added this to the Active Sprint milestone Jun 20, 2022
@cdrini cdrini self-assigned this Jun 20, 2022
@jimchamp jimchamp mentioned this issue Jun 22, 2022
Merged
13 tasks
@mekarpeles mekarpeles added Priority: 2 Important, as time permits. [managed] and removed Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Priority: 1 Do this week, receiving emails, time sensitive, . [managed] labels Jun 27, 2022
@cdrini cdrini modified the milestones: Sprint 2022-06, Next (proposed) Jul 6, 2022
@mekarpeles
Copy link
Member

This should be somewhat fixed with how things are presently done (#6665)

@cdrini cdrini added Lead: @mheiman Priority: 3 Issues that we can consider at our leisure. [managed] Affects: Librarians Issues related to features that librarians particularly need. [managed] and removed Needs: Detail Submitter needs to provide more detail for this issue to be assessed (see comments). [managed] Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Priority: 2 Important, as time permits. [managed] labels Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cdrini cdrini

Labels
Affects: Librarians Issues related to features that librarians particularly need. [managed] Lead: @mheiman Priority: 3 Issues that we can consider at our leisure. [managed] Type: Bug Something isn't working. [managed]
Projects
None yet
Milestone
The Icebox
Development

No branches or pull requests
2 participants
@mekarpeles @cdrini