Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message at Already Read Stats page does not work on merged works #7028

Open
onnotasler opened this issue Sep 28, 2022 · 0 comments
Open
Labels
Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Theme: Reading Stats

Comments

@onnotasler
Copy link
Collaborator

onnotasler commented Sep 28, 2022

I got an error message telling me that "3 works excluded due to missing data" from the "Most Read Authors" section. I assume it should tell me which books are missing (because that is what it does with the other stats), but in this case, I only get question marks:

(????) by
(????) by
(????) by

Upon looking into it, I saw that three of the books from my list had been merged and remained only as placeholders. Once I removed the books from the list and added them anew, the stats showed up correctly.

I doubt that this behaviour is intended, but it is mostly a cosmetic problem.

Relevant url?

https://openlibrary.org/people/USERNAME/books/already-read/stats

Steps to Reproduce

Add a book to your read list
Merge that book

  • Actual: There is simply a placeholder without any further info. (????) by

  • Expected: The book on the list is replaced by the book it was merged into.

Details

  • Logged in (Y/N)?
    Yes

  • Browser type/version?
    Firefox 104.0.2

  • Operating system?
    Suse Tumbleweed

  • Environment (prod/dev/local)?
    prod

Proposal & Constraints

I do not know how this problem could be technically solved, but at the moment, one can either clean the database or constantly render list entries unusable.

Stakeholders

Almost anyone who uses any list.

@mekarpeles mekarpeles added Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead Priority: 3 Issues that we can consider at our leisure. [managed] Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Theme: Reading Stats and removed Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead labels Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Theme: Reading Stats
Projects
None yet
Development

No branches or pull requests

2 participants