Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop importing movies from Amazon #8928

Open
seabelis opened this issue Mar 20, 2024 · 2 comments
Open

Stop importing movies from Amazon #8928

seabelis opened this issue Mar 20, 2024 · 2 comments
Labels
Affects: Data Issues that affect book/author metadata or user/account data. [managed] Lead: @scottbarnes Issues overseen by Scott (Community Imports) Needs: Investigation This issue/PR needs a root-cause analysis to determine a solution. [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Type: Bug Something isn't working. [managed]

Comments

@seabelis
Copy link
Collaborator

seabelis commented Mar 20, 2024

Problem

Amazon uses ASINs for their digital content. We have imported mass amounts of streaming movie ASINs.

Evidence / Screenshot

Relevant URL(s)

For example, https://openlibrary.org/works/OL33887074W/Hands_of_Stone

Reproducing the bug

  1. Go to ...
  2. Do ...
  • Expected behavior:
  • Actual behavior:

Context

  • Browser (Chrome, Safari, Firefox, etc):
  • OS (Windows, Mac, etc):
  • Logged in (Y/N): Y
  • Environment (prod, dev, local): prod

Notes from this Issue's Lead

Proposal & constraints

Stop importing streaming movies from Amazon.

Related files

Attached is a file with Work IDs reported by a volunteer.
reported movies.txt

Stakeholders

@hornc

@seabelis seabelis added Type: Bug Something isn't working. [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Affects: Data Issues that affect book/author metadata or user/account data. [managed] Needs: Lead labels Mar 20, 2024
@mekarpeles mekarpeles added Priority: 3 Issues that we can consider at our leisure. [managed] Needs: Investigation This issue/PR needs a root-cause analysis to determine a solution. [managed] Lead: @scottbarnes Issues overseen by Scott (Community Imports) and removed Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead labels Mar 25, 2024
@scottbarnes
Copy link
Collaborator

I looked at this very briefly and I will add here so I don't forget -- it looks as if we get fairly useful data out of the Products API that can almost certainly help us here, but we'd want to check more items to ensure we're getting the full scope of how movies are described: [{'url': 'https://www.amazon.com/dp/B01M5D29LB/?tag=internetarchi-20', 'source_records': ['amazon:B01M5D29LB'], 'isbn_10': [], 'isbn_13': [], 'price': '$3.79', 'price_amt': 379, 'title': 'Hands of Stone', 'cover': 'https://m.media-amazon.com/images/I/41nwS+Q9-QL. _SL500_.jpg', 'authors': [{'name': 'Robert De Niro'}, {'name': 'Edgar Ramirez'}, {'name': 'Ana De Armas'}, {'name': 'Usher Raymond IV'}, {'name': 'Ruben Blades'}, {'name': 'John Turturro'}, {'name': 'Ellen Barkin'}, {'name': 'Jonathan Jakubowicz'}, {'name': 'Jay Weisleder'}, {'name': 'Carlos Garcia De Paredes'}, {'name': 'Claudine Jakubowicz'}, {'name': 'Jonathan Jakubowicz'}], 'publishers': [], 'number_of_pages': None, 'edition_num': None, 'publish_date': None, 'product_group': 'Video On Demand', 'physical_format': 'prime video'}]

Emphasis here on product_group and physical_format.

@tfmorris
Copy link
Contributor

Rather than blacklisting 'physical_format': 'prime video' be sure to whitelist only the very few select acceptable formats allowed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Affects: Data Issues that affect book/author metadata or user/account data. [managed] Lead: @scottbarnes Issues overseen by Scott (Community Imports) Needs: Investigation This issue/PR needs a root-cause analysis to determine a solution. [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Type: Bug Something isn't working. [managed]
Projects
None yet
Development

No branches or pull requests

4 participants