Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lazy loading for covers in works merge tool #9201

Open
Tracked by #9121
RayBB opened this issue Apr 30, 2024 · 3 comments · May be fixed by #9312
Open
Tracked by #9121

Add lazy loading for covers in works merge tool #9201

RayBB opened this issue Apr 30, 2024 · 3 comments · May be fixed by #9312
Assignees
@Realmbird
Labels
Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this. Priority: 3 Issues that we can consider at our leisure. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]

Comments

@RayBB
Copy link
Collaborator

RayBB commented Apr 30, 2024

Right now we load all covers on the merge page even if they're not visible. If we add lazy loading to them it will massively cut down on requests. Should be a pretty good first issue.

Describe the problem that you'd like solved

image

Proposal & Constraints

https://openlibrary.org/works/merge?records=OL21868175W,OL41495W

Additional context

Stakeholders

@cdrini
@RayBB RayBB added Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead labels Apr 30, 2024
@RayBB RayBB mentioned this issue Apr 30, 2024
Open
13 tasks
@mekarpeles mekarpeles added Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] Priority: 3 Issues that we can consider at our leisure. [managed] and removed Needs: Lead Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] labels May 6, 2024
@Realmbird
Copy link
Contributor

@RayBB can I work on this

@github-actions github-actions bot added the Needs: Response Issues which require feedback from lead label May 7, 2024
@RayBB
Copy link
Collaborator Author

RayBB commented May 15, 2024

@Realmbird you are assigned now.

@mekarpeles mekarpeles removed the Needs: Response Issues which require feedback from lead label May 20, 2024
@Realmbird
Copy link
Contributor

@RayBB recreated problem docker compose exec -e PYTHONPATH=. web bash -c "./scripts/copydocs.py /works/OL21868175W /works/OL41495W"
Screenshot from 2024-05-21 12-33-11

@github-actions github-actions bot added the Needs: Response Issues which require feedback from lead label May 22, 2024
@Realmbird Realmbird linked a pull request May 22, 2024 that will close this issue
Open
@RayBB RayBB added Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this. and removed Needs: Response Issues which require feedback from lead labels May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Realmbird Realmbird

Labels
Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this. Priority: 3 Issues that we can consider at our leisure. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added lazy loading to merge books Realmbird/openlibrary
3 participants
@RayBB @mekarpeles @Realmbird