Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR assignment script fails when no "closes" statement is found in PR's body #9248

Closed
jimchamp opened this issue May 9, 2024 · 0 comments · Fixed by #9249
Closed

PR assignment script fails when no "closes" statement is found in PR's body #9248

jimchamp opened this issue May 9, 2024 · 0 comments · Fixed by #9249
Assignees
@jimchamp
Labels
Needs: Lead Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Type: Bug Something isn't working. [managed]

Comments

@jimchamp
Copy link
Collaborator

jimchamp commented May 9, 2024

Problem

The new PR assignment workflow fails whenever a newly opened PR does not contain a closes # statement in its body.

Evidence / Screenshot

Relevant URL(s)

Link to failed run:
https://github.com/internetarchive/openlibrary/actions/runs/9022233315/job/24791287498?pr=9247

Reproducing the bug

  1. Go to ...
  2. Do ...
  • Expected behavior:
  • Actual behavior:

Context

  • Browser (Chrome, Safari, Firefox, etc): N/A
  • OS (Windows, Mac, etc): N/A
  • Logged in (Y/N): N/A
  • Environment (prod, dev, local): prod

Notes from this Issue's Lead

Proposal & constraints

Related files

Stakeholders
@jimchamp jimchamp added Type: Bug Something isn't working. [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead labels May 9, 2024
@jimchamp jimchamp self-assigned this May 9, 2024
@jimchamp jimchamp mentioned this issue May 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jimchamp jimchamp

Labels
Needs: Lead Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Type: Bug Something isn't working. [managed]
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix PR assignment workflow jimchamp/openlibrary
1 participant
@jimchamp