Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Que for Sidekiq as job backend #1871

Merged
merged 6 commits into from Apr 12, 2021

Conversation

yulgolem
Copy link
Contributor

@yulgolem yulgolem commented Mar 5, 2021

Closes #645

Jobs workbench is accessible after logging in as administrator on /admin/sidekiq.
After merging #1873 it may be possible to increase concurrency in config/sidekiq.yml

Possible sidekiq systemd service example https://github.com/mperham/sidekiq/blob/master/examples/systemd/sidekiq.service
Run sidekiq manually: bundle exec sidekiq

@yulgolem yulgolem force-pushed the 645-2-gracefully-drop-que-email-jobs-sidekiq branch from 5dd51a7 to 8043612 Compare March 5, 2021 08:38
@yulgolem yulgolem force-pushed the 645-2-gracefully-drop-que-email-jobs-sidekiq branch 3 times, most recently from 708a821 to b34c011 Compare March 5, 2021 11:21
@yulgolem yulgolem force-pushed the 645-2-gracefully-drop-que-email-jobs-sidekiq branch 2 times, most recently from 4c064d1 to 79526c2 Compare March 12, 2021 08:28
@yulgolem yulgolem assigned ratM1n and unassigned OlegPhenomenon Mar 12, 2021
@yulgolem yulgolem marked this pull request as ready for review March 12, 2021 08:34
@ratM1n
Copy link

ratM1n commented Mar 18, 2021

ok, deployment script is ready.

  1. admin portal still has que admin interface instead sidekiq
  2. what will we do with old qued jobs?

@ratM1n ratM1n assigned yulgolem and unassigned ratM1n Mar 18, 2021
@vohmar
Copy link
Contributor

vohmar commented Mar 18, 2021

  1. if possible I would leave the que running for at least 2 days after we have switched to sidekiq, so the expiration emails, and confirmation cancellations would finish as expected but all new scheduled tasks would go to sidekiq meanwhile. Anything left hanging after 2 days is most probably zombie task anyway - cannot remember if we had any tasks that scheduled run time would be more than 48hr from the time of listing

@yulgolem yulgolem force-pushed the 645-2-gracefully-drop-que-email-jobs-sidekiq branch 2 times, most recently from c1b03d3 to 45ec411 Compare March 24, 2021 08:55
@vohmar
Copy link
Contributor

vohmar commented Mar 25, 2021

in parallel setup Sidekiq tasks worked fine but domain expiration email job in que ended with and error

image

@yulgolem yulgolem force-pushed the 645-2-gracefully-drop-que-email-jobs-sidekiq branch 2 times, most recently from 2d484d7 to 266f37d Compare April 5, 2021 08:07
@yulgolem
Copy link
Contributor Author

yulgolem commented Apr 5, 2021

Command rake data:migrate should be run after branch deploy.

@yulgolem yulgolem force-pushed the 645-2-gracefully-drop-que-email-jobs-sidekiq branch from 9f7820e to 687196b Compare April 12, 2021 12:23
@vohmar vohmar merged commit d6f6794 into master Apr 12, 2021
@vohmar vohmar deleted the 645-2-gracefully-drop-que-email-jobs-sidekiq branch June 8, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Que: jobs that send emails but fail must be expired in 48 hours
4 participants