Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce Zeitwerk class loader #1873

Merged
merged 1 commit into from Mar 9, 2021
Merged

Introduce Zeitwerk class loader #1873

merged 1 commit into from Mar 9, 2021

Conversation

yulgolem
Copy link
Contributor

@yulgolem yulgolem commented Mar 5, 2021 •
edited

Closes #1872

Need to be merged before #1871

@yulgolem yulgolem force-pushed the 1872-zeitwerk-migration branch 3 times, most recently from 57da745 to d0531c4 Compare March 5, 2021 13:37
@yulgolem yulgolem marked this pull request as ready for review March 5, 2021 14:24
@yulgolem yulgolem changed the title Fix namespaces for Zeitwerk class loader Introduce Zeitwerk class loader Mar 8, 2021
@yulgolem yulgolem mentioned this pull request Mar 8, 2021
Merged
@yulgolem yulgolem assigned vohmar and unassigned OlegPhenomenon Mar 8, 2021
@yulgolem
Copy link
Contributor Author

yulgolem commented Mar 8, 2021

Can be checked on staging as RAILS_ENV=staging bundle exec rake zeitwerk:check

@vohmar vohmar merged commit f47f1a9 into master Mar 9, 2021
@vohmar vohmar deleted the 1872-zeitwerk-migration branch June 8, 2021 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karlerikounapuu karlerikounapuu karlerikounapuu approved these changes

Assignees

@vohmar vohmar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow use of zeitwerk autoloader.
4 participants
@yulgolem @karlerikounapuu @vohmar @OlegPhenomenon