Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nullable Product Attributes #1197

Closed
MoritzRS opened this issue Jun 29, 2022 · 0 comments · Fixed by #1248
Closed

Nullable Product Attributes #1197

MoritzRS opened this issue Jun 29, 2022 · 0 comments · Fixed by #1248
Labels
bug Something isn't working
Milestone

Comments

@MoritzRS
Copy link
Contributor

MoritzRS commented Jun 29, 2022

Actual Behavior

Product Model (src/app/core/models/product/product.model.ts) specifies a property named attributes as a non nullable array.
In a customer project it turned out that the property is actually still nullable.
This causes and might cause problems because of the assumption that the property is an array and not nullable.

Expected Behavior

Either the type annotation indicates a nullable property type or the mapping is adjusted so the property really is non nullable.

AB#77768

@MoritzRS MoritzRS added the bug Something isn't working label Jun 29, 2022
@shauke shauke added this to the 3.1 milestone Aug 15, 2022
shauke pushed a commit that referenced this issue Aug 15, 2022
* product.attributes will always return at least an empty Array
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants