feat: localized product attributes #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sebastian-Haehnlein
force-pushed
the
feature/localized-product-attributes
branch
from
147e564
to
5ff3d94
Compare
shauke
approved these changes
Feb 10, 2020
shauke
requested changes
Feb 10, 2020
Sebastian-Haehnlein
force-pushed
the
feature/localized-product-attributes
branch
from
5ff3d94
to
ccda0b6
Compare
shauke
approved these changes
Feb 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Feature
What Is the Current Behavior?
Issue Number:
Closes #91
While localized calls to the
/products/<sku>REST resource return the product attribute values as localized values the attribute names are still returned in English. This will then result in a language mix in localized storefronts.What Is the New Behavior?
The attribute values as well as the attribute names should be returned in the requested locale with the
/products/<sku>call.Does this PR Introduce a Breaking Change?
[ ] Yes
[x] No