Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace the PNG image with a self explaining SVG image without text #1296

Merged
merged 8 commits into from
Oct 14, 2022

Conversation

andreassteinmann
Copy link
Collaborator

@andreassteinmann andreassteinmann commented Oct 12, 2022

PR Type

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:

What Is the Current Behavior?

Currently, the "Image Not Available" image includes text within the image. This should be prevented due to localization.

Issue Number: Relates to #625

What Is the New Behavior?

  • The PNG image is replaced by an SVG image.
  • The SVG image does not include text within the image any longer.
  • The SVG image is self explaining and there is no need to add localized text. Furthermore, if the text would be added using pure HTML text it is hardly readable on thumbnail images (minicart, thumbs in product detail page etc.).
  • The SVG image replaces the PNG in the same folder. It is not moved to a theme specific folder and the image reference is kept in the HTML component file(s) instead of SCSS.

Does this PR Introduce a Breaking Change?

[x] Yes
[ ] No

Other Information

The "Product Image Not Available" image is used for

  • product images
  • but also as a placeholder image for category images (until the category image is loaded)

Therefore both occurrences have to be tested.

How to test

Create a new product without product images and test the display of the "product image not available" SVG on the following pages:

  • Product List
  • PDP
  • Minicart
  • Cart
  • Checkout Review
  • Checkout Confirmation
  • My Account - Order / Requisition Details
  • My Account - Approval Details
  • My Account - Order Template

AB#80263

@shauke shauke added this to the 3.1 milestone Oct 12, 2022
@shauke shauke marked this pull request as ready for review October 13, 2022 14:34
Copy link
Member

@shauke shauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks fine now, except for the Firefox rendering issue.

image

andreassteinmann and others added 4 commits October 14, 2022 11:25
…vent display issues (image and surroinding element collapses to 0)

BREAKING CHANGES: replace the "product image not available" PNG image with an SVG image (without text inside the image) and adjust file references
@shauke shauke linked an issue Oct 14, 2022 that may be closed by this pull request
@shauke shauke merged commit 9a984da into develop Oct 14, 2022
@shauke shauke deleted the fix/replace-image-not-available branch October 14, 2022 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Theme-dependent not found images
2 participants