fix: repair loading of lazy extension components #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhhyi
force-pushed
the
fix/lazy-component-loading
branch
from
38c49ff
to
90b05d4
Compare
dhhyi
force-pushed
the
fix/lazy-component-loading
branch
2 times, most recently
from
b551242
to
7336b37
Compare
shauke
approved these changes
Sep 8, 2020
|
After this change lazy loading modules became lazy loaded at all again. Before they where part of the main bundle which was not the intended way. |
rinkeshrsys
pushed a commit
to rinkeshrsys/intershop-pwa
that referenced
this pull request
Sep 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Bugfix
[x] Build-related changes
[x] Application / infrastructure changes
What Is the Current Behavior?
Lazy components and extension stores are loaded without relation to their extension modules.
What Is the New Behavior?
Fixed.
Does this PR Introduce a Breaking Change?
[x] Yes
[ ] No
Other Information