fix: working and adjusted concardis-directdebit validation #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxKless
force-pushed
the
feature/formly-async-validation
branch
from
9e25fe3
to
f471a75
Compare
MaxKless
changed the title
M-Behr
previously approved these changes
Mar 2, 2021
SGrueber
requested changes
Mar 2, 2021
MaxKless
force-pushed
the
feature/formly-async-validation
branch
from
63b633e
to
a3837c3
Compare
SGrueber
approved these changes
Mar 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
What Is the Current Behavior?
https://jira.intershop.de/browse/CONCARDIS-393
What Is the New Behavior?
Serverside validation is now displayed after pressing submit, submit button is properly disabled and validation checkmarks are not shown if validation is not certain anymore (after first server validation)
Does this PR Introduce a Breaking Change?
[ ] Yes
[x] No
Other Information