feat: replace any typescript file by configuration #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhhyi
force-pushed
the
feat/replace-typescript-files-by-config
branch
from
5f2d22c
to
2232870
Compare
dhhyi
force-pushed
the
feat/replace-typescript-files-by-config
branch
from
9b92a83
to
b84211a
Compare
shauke
requested changes
Mar 19, 2021
Okay 😄 |
dhhyi
force-pushed
the
feat/replace-typescript-files-by-config
branch
from
02a1c09
to
fb0d45b
Compare
dhhyi
force-pushed
the
feat/replace-typescript-files-by-config
branch
from
fb0d45b
to
2cf4438
Compare
|
I took the opportunity to also sneak in an optimization and a test. 👍 |
shauke
approved these changes
Mar 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Feature
What Is the Current Behavior?
Environment specific overrides (#537) can only override HTML templates and component styles
What Is the New Behavior?
Any typescript file can be overridden by having the extension ".ts".
File overrides can be active for multiple configurations. For example
custom.service.brand1.brand2.tswill activate forng build -c brand1and also forng build -c brand2.Does this PR Introduce a Breaking Change?
[ ] Yes
[ ] No
Other Information
This is useful for projects for overriding functionality without introducing changes in ISH sources.