feat: Cost Center selection for checkout #807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SGrueber
previously requested changes
Aug 6, 2021
src/app/shared/components/checkout/cost-center-selection/cost-center-selection.component.ts
Outdated
Show resolved
Hide resolved
src/app/shared/components/checkout/cost-center-selection/cost-center-selection.component.ts
Outdated
Show resolved
Hide resolved
src/app/shared/components/checkout/cost-center-selection/cost-center-selection.component.html
Outdated
Show resolved
Hide resolved
cbratsch
force-pushed
the
feature/cost_center_selection
branch
from
b830064
to
4c08c4c
Compare
SGrueber
force-pushed
the
feature/cost_center_selection
branch
2 times, most recently
from
551d49c
to
c6e8799
Compare
SGrueber
force-pushed
the
feature/cost_center_selection
branch
from
f5265b9
to
8add917
Compare
M-Behr
requested changes
Aug 23, 2021
There was a problem hiding this comment.
Hi, it works really well. Here are some issues:
- Cost Center ID and name should be displayed in the buyer box at the end of checkout. this needs the appropriate fix of the ICM cost center REST interface (latest LTS patch)
- You select a cost center and go to checkout. If you click "Return to Cart" or you come back to the cart page somehow else, the cost center selection is empty. The selected cost center should be displayed. - this needs the appropriate fix of the ICM cost center REST interface (latest LTS patch)
SGrueber
force-pushed
the
feature/cost_center_selection
branch
from
9dd0f9a
to
e612521
Compare
M-Behr
approved these changes
Aug 30, 2021
added 10 commits
September 1, 2021 10:11
…basket cost center
shauke
force-pushed
the
feature/cost_center_selection
branch
from
5b7fcf2
to
ab168d5
Compare
shauke
force-pushed
the
feature/cost_center_selection
branch
from
ab168d5
to
dc49933
Compare
shauke
pushed a commit
that referenced
this pull request
Sep 1, 2021
Co-authored-by: Silke <s.grueber@intershop.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Feature
What Is the Current Behavior?
It is currently not possible to successfully enter a B2B checkout process if the logged in user is assigned to any cost center. For this a cost center selection is missing at the shopping cart page.
What Is the New Behavior?
Business Users can select a cost center in the checkout process, when assigned to one or multiple cost centers.
Does this PR Introduce a Breaking Change?
[x] No
Other Information
This feature does not include Cost Center Management functionalities.
AB#65623