Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update update sql script to write writer field for Subscriptions table #410

Merged
merged 3 commits into from
Aug 26, 2020
Merged

Update update sql script to write writer field for Subscriptions table #410

merged 3 commits into from
Aug 26, 2020

Conversation

Dos-Ph
Copy link
Contributor

@Dos-Ph Dos-Ph commented Aug 23, 2020 •
edited

#349

Changes

  1. Add writer file to subscription object
  2. Create function returning SubscriptionRepo based on store version
  3. Update Subscription handler to pass locality value
  4. Move previous /cockroach/subscription.go to /cockroach/subscription_v3.go. This file will be delete after rid db is migrated to v3.1.

vosst
vosst approved these changes Aug 24, 2020
View reviewed changes
Copy link
Contributor

@vosst vosst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one niggle inline.

@charlie-pisuraj charlie-pisuraj merged commit c789b2b into interuss:master Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vosst vosst vosst approved these changes

@BenjaminPelletier BenjaminPelletier Awaiting requested review from BenjaminPelletier

Assignees

@vosst vosst

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Dos-Ph @vosst @charlie-pisuraj