Fix shell scripts to pass linter #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't had a chance to investigate why, but this PR currently seems to break the docker_e2e.sh integration test (verified on local machine as well) |
barroco
force-pushed
the
fix-sh-lint
branch
from
fca4d24
to
5234d76
Compare
The PR was targeting the I updated the PR to target I had to add a filter to the linter to skip checks of the shell script in the |
BenjaminPelletier
approved these changes
Sep 29, 2021
BenjaminPelletier
added a commit
that referenced
this pull request
Oct 1, 2021
* [cleanup] Fix shell scripts to pass linter (#563) * Fix shell scripts to pass linter * Skip shell linter on submodule astm-utm * Fix #563 comments - unused variables * Fix #563 comments - boostrap script * [ci] azure-pipelines: Add linter to build step (#576) * azure-pipelines: Add linter to build step * azure-pipelines: Revert to preserve job labels and pipeline name * [deployment] Remove outdated files (#581) * test cases updated with delete in the end. * Script to run prober tests on local DSS instance * Prober test run on local dss instances * comments incorporated * removed outdated files * Update test_constraints_with_subscriptions to support 0.3.17 Co-authored-by: Michael Barroco <michael@orbitalize.com> Co-authored-by: Pratibha <40968555+pratibhagupta2109@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes shell scripts in order to pass shellcheck linter test.
Test command:
Please note that there are few TODO comments to be discussed with reviewers.