[rid] Add v2 endpoints #784
Conversation
Also, improve missing scopes error message, fix RID v2 scope string, improve Volume4D parsing error messages
|
|
||
|
|
||
| def test_ensure_clean_workspace_v2(ids, session_ridv2): | ||
| print('In test_ensure_clean_workspace, scope = {}'.format(SCOPE_SP)) |
There was a problem hiding this comment.
Should be test_ensure_clean_workspace_v2
There was a problem hiding this comment.
It is actually the only print in all tests. You may want to remove it.
| if err != nil { | ||
| return nil, stacktrace.Propagate(err, "Error parsing upper altitude of Volume3D") | ||
| } | ||
|
|
There was a problem hiding this comment.
Perhaps we would like to check that Exactly one outline must be specified.
| return &ridpb.SubscriberToNotify{ | ||
| Url: s.URL, | ||
| Subscriptions: []*ridpb.SubscriptionState{ | ||
| { |
There was a problem hiding this comment.
Is it correct to assume that there is always only one subscription ?
| return nil, stacktrace.NewErrorWithCode(dsserr.BadRequest, "Invalid ID format") | ||
| } | ||
|
|
||
| if !s.EnableHTTP { |
There was a problem hiding this comment.
I feel like this flag may benefit to be renamed since it is only used to disable URLs validation. I would propose to rename it as AllowHTTP or AllowHTTPBaseUrls to prevent confusion. Indeed, I got mislead thinking that this was linked to the listening protocol of the DSS server.
There was a problem hiding this comment.
The command option description is actually not accurate.
| ) | ||
|
|
||
| if et := req.GetEarliestTime(); et != nil { | ||
| ts := et.AsTime() |
There was a problem hiding this comment.
Would it makes sense to call first CheckValid?
There was a problem hiding this comment.
Sure -- adjusted, and adjusted in v1 as well
| } | ||
|
|
||
| if lt := req.GetLatestTime(); lt != nil { | ||
| ts := lt.AsTime() |
There was a problem hiding this comment.
Similar: Would it makes sense to call first CheckValid?
There was a problem hiding this comment.
Sure -- adjusted, and adjusted in v1 as well
This PR adds support for RID v2 (ASTM F3411 second version) endpoints, as well as prober tests to validate those endpoints.
Due to a limitation in the standards, v1 and v2 endpoints are only almost interoperable and not actually interoperable. The ideal solution to this problem would have been for the ASTM standards to specify protocols along with the URLs (e.g., "my v1 /flights endpoint is https://example.com/rid/v1/uss/flights", "my v2 base URL is https://example.com/rid/v2"), and this convention will hopefully be adopted in future versions of the standard. In the mean time, see the documentation in interfaces/rid/README.md for the approach taken in this DSS implementation.