Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Performance Monitoring traces sampler callback #74

Merged
merged 15 commits into from
Jul 2, 2024

Conversation

Hugo-C
Copy link
Contributor

@Hugo-C Hugo-C commented May 18, 2024

Following discussion in #73 , this should allow the usage of traces_sampler as exposed by Sentry.
I kept the fairing method for compatibility.
I need to check the fairing_init_with_specific_traces_sampler that seems to be failing for some reasons.

@Hugo-C
Copy link
Contributor Author

Hugo-C commented May 18, 2024

For the failing test, if fairing_init is duplicated it'll sometime fail. The problem is not with fairing_init_with_specific_traces_sampler then. So I guess we can't have Hub, Rocket or something else in parallel :(
I'll add a lock so these two tests run in sequence.
EDIT: using Hub::current() instead of Hub::main() seems to be working fine.

@Hugo-C Hugo-C marked this pull request as ready for review May 25, 2024 11:55
Copy link
Owner

@intgr intgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Some initial thoughts.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@Hugo-C
Copy link
Contributor Author

Hugo-C commented Jun 7, 2024

@intgr Thanks for the review. Please take another look when you have some time.

@intgr
Copy link
Owner

intgr commented Jun 8, 2024

Sorry, will try to get to it tomorrow. I had a brief look some days ago and it seemed pretty close to finished.

Don't hesitate to ping me again if I drop the ball 😅

Copy link
Owner

@intgr intgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience. :) I found some more suggestions.

src/lib.rs Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
tests/tests.rs Outdated Show resolved Hide resolved
examples/performance.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
examples/performance.rs Show resolved Hide resolved
examples/performance.rs Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@Hugo-C
Copy link
Contributor Author

Hugo-C commented Jul 1, 2024

Thanks for your patience. :) I found some more suggestions.

I had some busy weeks. The PR should be all good now, I can also squash the commits if needed.

Copy link
Owner

@intgr intgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me, thanks!

@intgr
Copy link
Owner

intgr commented Jul 2, 2024

I can also squash the commits if needed.

Nah, I use 'squash and merge'

@intgr intgr changed the title Add traces sampler integration feat: Performance Monitoring traces sampler callback Jul 2, 2024
@intgr intgr merged commit a403a63 into intgr:master Jul 2, 2024
1 check passed
@github-actions github-actions bot mentioned this pull request Jul 2, 2024
@intgr
Copy link
Owner

intgr commented Jul 2, 2024

Should be released now as rocket-sentry v0.18.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants