-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Performance Monitoring traces sampler callback #74
Conversation
For the failing test, if |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Some initial thoughts.
Co-authored-by: Marti Raudsepp <marti@juffo.org>
3a2de52
to
31869cc
Compare
@intgr Thanks for the review. Please take another look when you have some time. |
Sorry, will try to get to it tomorrow. I had a brief look some days ago and it seemed pretty close to finished. Don't hesitate to ping me again if I drop the ball 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your patience. :) I found some more suggestions.
Co-authored-by: Marti Raudsepp <marti@juffo.org>
I had some busy weeks. The PR should be all good now, I can also squash the commits if needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks all good to me, thanks!
Nah, I use 'squash and merge' |
Should be released now as |
Following discussion in #73 , this should allow the usage of
traces_sampler
as exposed by Sentry.I kept the
fairing
method for compatibility.I need to check the
fairing_init_with_specific_traces_sampler
that seems to be failing for some reasons.