fix: drop node v14 #1399
Merged
fix: drop node v14 #1399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution! node v14 has already passed LTS, so I've changed the title name of this PR :) |
|
Hello contributors. I'd like to know, if the new version 9.3 (or higher) relies on any Node 16+ specific features?
It's fine to use Node 16 in CI, but it would be harmless for users that still running a Node 14 with their own risk? I'm embarrassing to say but I'm still not able to upgrade all my old projects to Node 16+ due to breaking changes of Node, e.g. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No related issues.
Node versions specified in the codebase and docs are inconsistent.
This PR is to unify Node versions to 16 for 2 reasons:
.github/workflows/ci.yml).github/workflows/ci.ymlis newer than other places (e.g. commit topackage.json)