Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: manually add triple slash directive to message-compiler #1766

Conversation

BobbieGoede
Copy link
Contributor

@BobbieGoede BobbieGoede commented Mar 15, 2024

Resolves #1760 (tested locally using the provided reproduction)

Not sure if this would cause other issues, I haven't tested this in more projects.

After spending some time trying to figure out why the triple slash directive is being added, I gave up. The actual problem in #1760 is the path inside the directive, so after adding one manually I found out that this removes the directive from the build (huh?).

@kazupon kazupon added the Type: Bug Bug or Bug fixes label Mar 15, 2024
Copy link
Member

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, It's really hacky 😅
Thanks!
I've checked it in my local!

LGTM!

@kazupon kazupon merged commit d1aadbe into intlify:master Mar 15, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Bug or Bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v9.10.0] @intlify/message-compiler publishing missing TypeScript reference
2 participants