Changing to connect everytime #25
Conversation
|
should the client-function be integrated into the invoke-function? |
|
No its needed for fns like doc and ops and it carries the path context, so it has use outside. |
|
requested changes applied |
|
will adapt the documentation now |
|
The tests need fn name changes too right? |
src/clj_docker_client/core.clj
Outdated
| (.callTimeout (timeout-from (:call-timeout timeouts))))] | ||
| {:client (.build builder+opts) | ||
| :socket socket})) | ||
| (:import (okhttp3 OkHttpClient$Builder))) |
There was a problem hiding this comment.
This import can be removed?
TimoKramer
force-pushed
the
master
branch
2 times, most recently
from
8aa17de
to
bc675f8
Compare
|
panic! and connect* are now in requests-ns. maybe panic should be moved back to core?! I wasn't sure... |
|
I think panic! should be moved back as its supposed to handle public APIs |
Since we had problems using this lib in bob, we decided to change the behaviour to connect everytime you call invoke. The connect function is now deprecated and only returns a map to avoid breaking the api. You still are able to use client like before but it is discouraged now to use connect and only using invoke is also sufficient. I moved the connect-function to the requests namespace because it is not part of the official api but is used with the fetch-function and therefore should reside with it. The panic! function has to be in the requests namespace as well because otherwise we would have a cyclic dependency. The documentation is changed accordingly and fetch needs to call the for now unofficial function connect*. Refers into-docker#20
|
alright. added the uri-check and inlined the timeouts for the deprecated connect. I need the panic! in the request-ns because using it as an import from core does not work because of cyclic dependency. we could make a util-ns?! |
|
Ah yes, we can go ahead with it being in requests ns. |
|
from my point of view it should be fine to merge and release the new version. |
Since we had problems using this lib in bob, we decided to change the
behaviour to connect everytime you call invoke. The connect function is
now deprecated and only returns a map to avoid breaking the api. You
still are able to use client like before but it is discouraged now
to use connect and only using invoke is also sufficient.
Refers #20