Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the possibility to set a custom extension path #67

Closed
wants to merge 1 commit into from

Conversation

matyo91
Copy link

@matyo91 matyo91 commented Jun 14, 2018

When using launcher, we can set a custom path to locate the extension folder.

@sangaline
Copy link
Member

Thanks for submitting a pull request. We're actually working on some broader refactoring in general that will make it easier to specify things like command line arguments and other browser settings (see: #55). Just out of curiosity, what's your use-case for changing the extension directory? Are you using a custom build of the extension, or adding additional content scripts? We might be able to find a way to provide your desired functionality through the library's API rather than needing to customize the extension itself.

@matyo91
Copy link
Author

matyo91 commented Jun 16, 2018

Hi, to answer the question, i'm currently not using a custom extension.
All work fine if you clone the directory and work inside. But if you consider yarn install remote-browser, here is an instance of a simple case :

# node.js
var launchChrome = require('remote-browser').launchChrome
launchChrome('http://www.google.fr')

Then :

$ yarn add remote-browser
$ node node.js

It will be ./node_modules/remote-browser/index.js that will be loaded, and the script will not find the directory ../dist/extension relatively from ./node_modules/remote-browser/index.js file.

That why i wanted to add a custom extension path.

@sangaline
Copy link
Member

Thanks, that's definitely not the intended behavior. We'll get a fix for the underlying problem out ASAP.

@ghost ghost assigned sangaline Jun 16, 2018
@ghost ghost added the in progress label Jun 16, 2018
sangaline added a commit that referenced this pull request Jun 16, 2018
The resolution of the extension directory was broken after the build outputs
were moved out of `dist/` during packaging, so that the web client could be
imported as `remote-browser/web-client` (see:
[3b125d2](3b125d2).
This just removes `dist` from the path when resolving the extension file.

Connects #67
Closes #68

Merges #69
@sangaline
Copy link
Member

This behavior should be fixed in v0.0.13, please let me know if you're still running into issues. We will add the ability to add additional extensions in the near future, but it's part of a larger refactoring of the interface.

@sangaline sangaline closed this Jun 16, 2018
@ghost ghost removed the in progress label Jun 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants