Options in Oj

[stereobooster]

WIP. Need to decide what to do with new Oj gem.

New Oj has json compatibility mode e.g. it is identical to original JSON gem. Which should be used here, buut in this mode Oj only accept options valid for JSON, nothing else. So this can be brake change for developer who used some special options for Oj.

PS Do we need compatibility with version 2.x?

Related ohler55/oj#376 cc @ohler55

[ohler55]

Looks like the tests are using an older Oj. I think the Gemspec needs to be updated.

[stereobooster]

On the second thought those changes don't make much sense.

defaults :load, :mode => :strict, :symbolize_keys => false - strict is ideal for loading, because this is just JSON-specification compatibility mode. symbolize_keys is still makes sense, even so this is invalid option in JSON gem.

defaults :dump, :mode => :compat, :time_format => :ruby, :use_to_json => true - compat is the same as json in new Oj. I suppose time_format is useless with new Oj, but we can leave it for backward compatibility.

[rwz]

Wait, why do we need MultiJson support the Oj's compatibility mode again? I don't get it.

You can use Oj's hack to speed-up code that uses stdlib JSON and also enable MultiJson's Oj adapter to make sure that MultiJson is doing the right thing.

[stereobooster]

Just a small note Oj 3 in compat mode ignores use_to_json AFAIK

[ohler55]

That is correct. It is as if use_to_json is always true or rather it follows the json gem rules for when to_json is called. This table http://www.ohler.com/oj/doc/file.Modes.html explains what options are applicable.