please namespace okjson to avoid conflicts with other libraries #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents errors when multi_json is used alongside another library that also bundles okjson.
|
Hey @kr! Thanks for OkJson! Funnily enough I have already done this in a branch (https://github.com/intridea/multi_json/tree/okjson_to_json_fallback) which I need to merge in. I saw your advice in the OkJson readme last week and made the change as we have experienced this issue before. I'm closing this PR as I will merge in the branch tomorrow. Thanks again! Josh |
|
Nice, sounds good! And you're welcome, I'm glad people are finding okjson useful! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I've had reports of people getting errors when using two
libraries that both bundle okjson. These errors are usually
innocuous -- it's just things like constants being defined
twice -- but still it'd be nice to avoid them. (And it's more
serious if someone has patched their bundled copy of
okjson to modify its behavior.)
The solution we came up with was to request that libraries
bundling okjson rename the module to avoid conflicts. So
here's a patch to do that.