Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve NMS implementation #1173

Merged
merged 1 commit into from
Nov 28, 2023
Merged

improve NMS implementation #1173

merged 1 commit into from
Nov 28, 2023

Conversation

borongyuan
Copy link
Contributor

This fixes the problem of extracting multiple keypoints at the same location. Previously, where prob is greater than the threshold were extracted as keypoints.

cv::findNonZero(prob > threshold_, kpts);

auto kpts = (prob_ > threshold_);

Therefore in NMS, local maximums are found first, and then neighbors are suppressed. Now for loop closure, it works fine when the image resolution is 400P or 800P. For odometry, 800P is not suitable for F2M, but is suitable for F2F. Because the position of keypoints is more jittery.

@matlabbe matlabbe merged commit 0876603 into introlab:master Nov 28, 2023
7 checks passed
@matlabbe
Copy link
Member

Alright, thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants