Add ceiling filter to rtabmap-export #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Timple
reviewed
Nov 8, 2021
| @@ -115,6 +115,8 @@ void showUsage() | |||
| " --ymax # Maximum range on Y axis to keep nodes to export.\n" | |||
| " --zmin # Minimum range on Z axis to keep nodes to export.\n" | |||
| " --zmax # Maximum range on Z axis to keep nodes to export.\n" | |||
| " --filter_ceiling # Filter points over a custom height (dafault 2 m, 0=disabled).\n" | |||
There was a problem hiding this comment.
See the final version here:
Lines 118 to 119 in ddd5eb5
There was a problem hiding this comment.
Whups, sorry.
I was quickly browsing to see what changed in the new version. Should have looked at the end-result 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a parameter in rtabmap-export to filter ceiling if wanted.