Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set new theme in init(coder:) to apply to cardCellMargins in storyboards #200

Merged
merged 2 commits into from
Nov 11, 2019
Merged

set new theme in init(coder:) to apply to cardCellMargins in storyboards #200

merged 2 commits into from
Nov 11, 2019

Conversation

rcole34
Copy link
Contributor

@rcole34 rcole34 commented Nov 5, 2019

Before you make a Pull Request, read the important guidelines:

Issue Link 🔗

  • Is this a bug fix or a feature?
  • Does it break any existing functionality?

Goals of this PR 🎉

  • Why is the change important?
  • What does this fix?
  • How far has it been tested?

How Has This Been Tested 🔍

Please let us know if you have tested your PR and if we need to reproduce the issues. Also, please let us know if we need any relevant information for running the tests.

  • User Interface Testing
  • Application Testing

Test Configuration 👾

  • Xcode version:
  • Device/Simulator
  • iOS version || MacOSX version

Things to check on 🎯

  • My Pull Request code follows the coding standards and styles of the project
  • I have worked on unit tests and reviewed my code to the best of my ability
  • I have used comments to make other coders understand my code better
  • My changes are good to go without any warnings
  • I have added unit tests both for the happy and sad path
  • All of my unit tests pass successfully before pushing the PR
  • I have made sure all dependent downstream changes impacted by my PR are working

@badrinathvm
Copy link
Contributor

@rcole34
required init?(coder: NSCoder) { CardPartsMintTheme().apply() super.init(coder: coder) } gets called much before than ApplDelegate's func application(_ application: UIApplication, didFinishLaunchingWithOptions method.. This is good.

Copy link
Contributor

@croossin croossin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be good to also update the documentation for Applying a theme since we state you should set in AppDelegate -- just add an extra note about using Storyboards.

@croossin
Copy link
Contributor

Looks good.

@croossin croossin merged commit 3d52c4a into intuit:master Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants