Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make scrollViewDidScroll so it can be overridden #247

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jmjordan
Copy link
Contributor

@jmjordan jmjordan commented May 7, 2020

Before you make a Pull Request, read the important guidelines:

Issue Link 🔗

  • Is this a bug fix or a feature?
  • Feature
  • Does it break any existing functionality?
  • No

Goals of this PR 🎉

  • Why is the change important?
  • It allows overriding of scrollViewDidScroll
  • What does this fix?
  • N/A
  • How far has it been tested?
  • Minimally

How Has This Been Tested 🔍

Please let us know if you have tested your PR and if we need to reproduce the issues. Also, please let us know if we need any relevant information for running the tests.

  • User Interface Testing
  • Application Testing

Test Configuration 👾

  • Xcode version:
  • 11.3.1
  • Device/Simulator
  • iPhone 11
  • iOS version || MacOSX version
  • 13.4

Things to check on 🎯

  • My Pull Request code follows the coding standards and styles of the project
  • I have worked on unit tests and reviewed my code to the best of my ability
  • I have used comments to make other coders understand my code better
  • My changes are good to go without any warnings
  • I have added unit tests both for the happy and sad path
  • All of my unit tests pass successfully before pushing the PR
  • I have made sure all dependent downstream changes impacted by my PR are working

@jmjordan jmjordan marked this pull request as ready for review May 7, 2020 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant