-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of CardPart Video View #265
Conversation
@croossin @bharathmurs this seems to be working fine for Badari, but I wasn't sure if this is the "CardParts" way of adding a subview from another controller? I was thinking he might need to set the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Just curious does this support picture-in-picture out of the box |
Before you make a Pull Request, read the important guidelines:
Implementation of CardPartVideoView.
Issue Link 🔗
Goals of this PR 🎉
How Has This Been Tested 🔍
Please let us know if you have tested your PR and if we need to reproduce the issues. Also, please let us know if we need any relevant information for running the tests.
Test Configuration 👾
Things to check on 🎯