Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all contributors: add ability to add non-code contributions #1148

Merged
merged 11 commits into from
Apr 14, 2020

Conversation

hipstersmoothie
Copy link
Collaborator

@hipstersmoothie hipstersmoothie commented Apr 14, 2020

What Changed

see title

Why

closes #1147

Contributions

Todo:

  • Add tests
  • Add docs
📦 Published PR as canary version: under canary scope @auto-canary@9.26.9-canary.1148.14918.0

✨ Test out this PR locally via:

npm install @auto-canary/bot-list@9.26.9-canary.1148.14918.0
npm install @auto-canary/auto@9.26.9-canary.1148.14918.0
npm install @auto-canary/core@9.26.9-canary.1148.14918.0
npm install @auto-canary/all-contributors@9.26.9-canary.1148.14918.0
npm install @auto-canary/brew@9.26.9-canary.1148.14918.0
npm install @auto-canary/chrome@9.26.9-canary.1148.14918.0
npm install @auto-canary/cocoapods@9.26.9-canary.1148.14918.0
npm install @auto-canary/conventional-commits@9.26.9-canary.1148.14918.0
npm install @auto-canary/crates@9.26.9-canary.1148.14918.0
npm install @auto-canary/exec@9.26.9-canary.1148.14918.0
npm install @auto-canary/first-time-contributor@9.26.9-canary.1148.14918.0
npm install @auto-canary/gh-pages@9.26.9-canary.1148.14918.0
npm install @auto-canary/git-tag@9.26.9-canary.1148.14918.0
npm install @auto-canary/gradle@9.26.9-canary.1148.14918.0
npm install @auto-canary/jira@9.26.9-canary.1148.14918.0
npm install @auto-canary/maven@9.26.9-canary.1148.14918.0
npm install @auto-canary/npm@9.26.9-canary.1148.14918.0
npm install @auto-canary/omit-commits@9.26.9-canary.1148.14918.0
npm install @auto-canary/omit-release-notes@9.26.9-canary.1148.14918.0
npm install @auto-canary/released@9.26.9-canary.1148.14918.0
npm install @auto-canary/s3@9.26.9-canary.1148.14918.0
npm install @auto-canary/slack@9.26.9-canary.1148.14918.0
npm install @auto-canary/twitter@9.26.9-canary.1148.14918.0
npm install @auto-canary/upload-assets@9.26.9-canary.1148.14918.0
# or 
yarn add @auto-canary/bot-list@9.26.9-canary.1148.14918.0
yarn add @auto-canary/auto@9.26.9-canary.1148.14918.0
yarn add @auto-canary/core@9.26.9-canary.1148.14918.0
yarn add @auto-canary/all-contributors@9.26.9-canary.1148.14918.0
yarn add @auto-canary/brew@9.26.9-canary.1148.14918.0
yarn add @auto-canary/chrome@9.26.9-canary.1148.14918.0
yarn add @auto-canary/cocoapods@9.26.9-canary.1148.14918.0
yarn add @auto-canary/conventional-commits@9.26.9-canary.1148.14918.0
yarn add @auto-canary/crates@9.26.9-canary.1148.14918.0
yarn add @auto-canary/exec@9.26.9-canary.1148.14918.0
yarn add @auto-canary/first-time-contributor@9.26.9-canary.1148.14918.0
yarn add @auto-canary/gh-pages@9.26.9-canary.1148.14918.0
yarn add @auto-canary/git-tag@9.26.9-canary.1148.14918.0
yarn add @auto-canary/gradle@9.26.9-canary.1148.14918.0
yarn add @auto-canary/jira@9.26.9-canary.1148.14918.0
yarn add @auto-canary/maven@9.26.9-canary.1148.14918.0
yarn add @auto-canary/npm@9.26.9-canary.1148.14918.0
yarn add @auto-canary/omit-commits@9.26.9-canary.1148.14918.0
yarn add @auto-canary/omit-release-notes@9.26.9-canary.1148.14918.0
yarn add @auto-canary/released@9.26.9-canary.1148.14918.0
yarn add @auto-canary/s3@9.26.9-canary.1148.14918.0
yarn add @auto-canary/slack@9.26.9-canary.1148.14918.0
yarn add @auto-canary/twitter@9.26.9-canary.1148.14918.0
yarn add @auto-canary/upload-assets@9.26.9-canary.1148.14918.0

@hipstersmoothie hipstersmoothie added the minor Increment the minor version when merged label Apr 14, 2020
@codecov
Copy link

codecov bot commented Apr 14, 2020

Codecov Report

Merging #1148 into master will increase coverage by 0.02%.
The diff coverage is 82.60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1148      +/-   ##
==========================================
+ Coverage   81.48%   81.50%   +0.02%     
==========================================
  Files          53       53              
  Lines        3787     3856      +69     
  Branches      762      821      +59     
==========================================
+ Hits         3086     3143      +57     
- Misses        511      518       +7     
- Partials      190      195       +5     
Impacted Files Coverage Δ
plugins/all-contributors/src/index.ts 84.84% <82.60%> (-1.61%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b50d7b...7ccfcef. Read the comment docs.

@intuit intuit deleted a comment from adierkens Apr 14, 2020
@hipstersmoothie hipstersmoothie merged commit e606d27 into master Apr 14, 2020
@hipstersmoothie hipstersmoothie deleted the extra-contributors branch April 14, 2020 19:23
@adierkens
Copy link
Collaborator

🚀 PR was released in v9.27.0 🚀

@adierkens adierkens added the released This issue/pull request has been released. label Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All Contributors: Add contributions in the PR
2 participants