Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return 0.0.0 as default when no version found in gradle properties #1396

Merged
merged 1 commit into from
Aug 20, 2020

Conversation

rachanamamillapalli
Copy link

Addressing #1276

To return 0.0.0 instead of throwing error when version is not found in default properties

Todo:

  • Add tests
  • Add docs

@codecov
Copy link

codecov bot commented Jul 23, 2020

Codecov Report

Merging #1396 into master will decrease coverage by 0.02%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1396      +/-   ##
==========================================
- Coverage   81.07%   81.04%   -0.03%     
==========================================
  Files          56       56              
  Lines        4206     4205       -1     
  Branches      876      876              
==========================================
- Hits         3410     3408       -2     
- Misses        557      558       +1     
  Partials      239      239              
Impacted Files Coverage Δ
plugins/gradle/src/index.ts 74.32% <50.00%> (-1.68%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d44c6e...dfcc6a0. Read the comment docs.

@rachanamamillapalli
Copy link
Author

@rbellamy @hipstersmoothie

@hipstersmoothie
Copy link
Collaborator

@rbellamy Could you review this?

Will this work? does this imply that the version is never in the pom? or will the plugin add the version to the pom after first publish

@hipstersmoothie hipstersmoothie merged commit 23ffc33 into intuit:master Aug 20, 2020
@hipstersmoothie hipstersmoothie added the patch Increment the patch version when merged label Aug 20, 2020
@adierkens
Copy link
Collaborator

🚀 PR was released in v9.50.12 🚀

@adierkens adierkens added the released This issue/pull request has been released. label Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants