Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add timeout when verifying auth to remote #1632

Merged
merged 1 commit into from
Nov 4, 2020
Merged

Conversation

hipstersmoothie
Copy link
Collaborator

@hipstersmoothie hipstersmoothie commented Nov 4, 2020

What Changed

Add timeout when verifying auth to remote

Why

git push --dry-run was timing out on our jenkins. It was taking 7 minutes to timeout

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major
📦 Published PR as canary version: under canary scope @auto-canary@10.2.3-canary.1632.20161.0

✨ Test out this PR locally via:

npm install @auto-canary/bot-list@10.2.3-canary.1632.20161.0
npm install @auto-canary/auto@10.2.3-canary.1632.20161.0
npm install @auto-canary/core@10.2.3-canary.1632.20161.0
npm install @auto-canary/all-contributors@10.2.3-canary.1632.20161.0
npm install @auto-canary/brew@10.2.3-canary.1632.20161.0
npm install @auto-canary/chrome@10.2.3-canary.1632.20161.0
npm install @auto-canary/cocoapods@10.2.3-canary.1632.20161.0
npm install @auto-canary/conventional-commits@10.2.3-canary.1632.20161.0
npm install @auto-canary/crates@10.2.3-canary.1632.20161.0
npm install @auto-canary/docker@10.2.3-canary.1632.20161.0
npm install @auto-canary/exec@10.2.3-canary.1632.20161.0
npm install @auto-canary/first-time-contributor@10.2.3-canary.1632.20161.0
npm install @auto-canary/gem@10.2.3-canary.1632.20161.0
npm install @auto-canary/gh-pages@10.2.3-canary.1632.20161.0
npm install @auto-canary/git-tag@10.2.3-canary.1632.20161.0
npm install @auto-canary/gradle@10.2.3-canary.1632.20161.0
npm install @auto-canary/jira@10.2.3-canary.1632.20161.0
npm install @auto-canary/maven@10.2.3-canary.1632.20161.0
npm install @auto-canary/microsoft-teams@10.2.3-canary.1632.20161.0
npm install @auto-canary/npm@10.2.3-canary.1632.20161.0
npm install @auto-canary/omit-commits@10.2.3-canary.1632.20161.0
npm install @auto-canary/omit-release-notes@10.2.3-canary.1632.20161.0
npm install @auto-canary/pr-body-labels@10.2.3-canary.1632.20161.0
npm install @auto-canary/released@10.2.3-canary.1632.20161.0
npm install @auto-canary/s3@10.2.3-canary.1632.20161.0
npm install @auto-canary/slack@10.2.3-canary.1632.20161.0
npm install @auto-canary/twitter@10.2.3-canary.1632.20161.0
npm install @auto-canary/upload-assets@10.2.3-canary.1632.20161.0
# or 
yarn add @auto-canary/bot-list@10.2.3-canary.1632.20161.0
yarn add @auto-canary/auto@10.2.3-canary.1632.20161.0
yarn add @auto-canary/core@10.2.3-canary.1632.20161.0
yarn add @auto-canary/all-contributors@10.2.3-canary.1632.20161.0
yarn add @auto-canary/brew@10.2.3-canary.1632.20161.0
yarn add @auto-canary/chrome@10.2.3-canary.1632.20161.0
yarn add @auto-canary/cocoapods@10.2.3-canary.1632.20161.0
yarn add @auto-canary/conventional-commits@10.2.3-canary.1632.20161.0
yarn add @auto-canary/crates@10.2.3-canary.1632.20161.0
yarn add @auto-canary/docker@10.2.3-canary.1632.20161.0
yarn add @auto-canary/exec@10.2.3-canary.1632.20161.0
yarn add @auto-canary/first-time-contributor@10.2.3-canary.1632.20161.0
yarn add @auto-canary/gem@10.2.3-canary.1632.20161.0
yarn add @auto-canary/gh-pages@10.2.3-canary.1632.20161.0
yarn add @auto-canary/git-tag@10.2.3-canary.1632.20161.0
yarn add @auto-canary/gradle@10.2.3-canary.1632.20161.0
yarn add @auto-canary/jira@10.2.3-canary.1632.20161.0
yarn add @auto-canary/maven@10.2.3-canary.1632.20161.0
yarn add @auto-canary/microsoft-teams@10.2.3-canary.1632.20161.0
yarn add @auto-canary/npm@10.2.3-canary.1632.20161.0
yarn add @auto-canary/omit-commits@10.2.3-canary.1632.20161.0
yarn add @auto-canary/omit-release-notes@10.2.3-canary.1632.20161.0
yarn add @auto-canary/pr-body-labels@10.2.3-canary.1632.20161.0
yarn add @auto-canary/released@10.2.3-canary.1632.20161.0
yarn add @auto-canary/s3@10.2.3-canary.1632.20161.0
yarn add @auto-canary/slack@10.2.3-canary.1632.20161.0
yarn add @auto-canary/twitter@10.2.3-canary.1632.20161.0
yarn add @auto-canary/upload-assets@10.2.3-canary.1632.20161.0

@hipstersmoothie hipstersmoothie added the patch Increment the patch version when merged label Nov 4, 2020
@hipstersmoothie hipstersmoothie force-pushed the verify-timeout branch 4 times, most recently from 6fa318c to fe47791 Compare November 4, 2020 20:53
@codecov
Copy link

codecov bot commented Nov 4, 2020

Codecov Report

Merging #1632 into master will decrease coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1632      +/-   ##
==========================================
- Coverage   80.29%   80.27%   -0.02%     
==========================================
  Files          61       61              
  Lines        4643     4655      +12     
  Branches     1008     1059      +51     
==========================================
+ Hits         3728     3737       +9     
- Misses        630      632       +2     
- Partials      285      286       +1     
Impacted Files Coverage Δ
packages/core/src/utils/verify-auth.ts 85.71% <66.66%> (-14.29%) ⬇️
packages/core/src/auto.ts 78.40% <0.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36b284b...a962ba2. Read the comment docs.

@hipstersmoothie hipstersmoothie merged commit a4197d3 into master Nov 4, 2020
@hipstersmoothie hipstersmoothie deleted the verify-timeout branch November 4, 2020 22:23
@adierkens
Copy link
Collaborator

🚀 PR was released in v10.2.3 🚀

@adierkens adierkens added the released This issue/pull request has been released. label Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants