Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixing gradle issue #2116
fixing gradle issue #2116
Changes from 3 commits
f7a3ce6
421b41f
fde8db3
972fa56
78123b1
c9b8996
ce3ec32
cf26a88
7ae6d6a
5a1bf13
f5c100e
e3fc4bd
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code is the same as the other block in the conditional. At the very least we need to ensure that the
buildFlag
is respected and the projectsbuildTasks
is called to ensure that anything relying on the version string is re-built.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking that we'll probably also want to ensure that other features of the release plugin are still being utilized here, like
checkSnapshotDependencies
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ykhandelwal913 This looks better. The only thing I see here that is a little confusing is the
createScmAdapter
,initScmAdapter
, andunSnapshotVersion
task calls.For both
createScmAdapter
andinitScmAdapter
, I can maybe see some issues here if those aren't initialized by some dependent task, but would like to know for sure if you saw an error without them.For
unSnapshotVersion
, I think we should try to avoid this one if we can since this would actually change the version in the version file, which we don't want because we are already changing it ourselves withupdateVersion
.Does that make sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
createScmAdapter and initScmAdapter are internal dependency to subsequent task. Hence added them. Removed the unSnapshot version