Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

not working multiple directories in repository #2

Closed
hchemanchula opened this issue Apr 11, 2019 · 7 comments
Closed

not working multiple directories in repository #2

hchemanchula opened this issue Apr 11, 2019 · 7 comments
Assignees
@marcellodesales
Labels
bug
Milestone
v1.2.0

Comments

@hchemanchula
Copy link

commits to sub folders in the repository are not working
@marcellodesales
Copy link
Member

@hchemanchula I will take care of it...

@marcellodesales marcellodesales self-assigned this Apr 26, 2019
@marcellodesales
Copy link
Member

Validation missing files in dirs

  • Fixing the dir creation, I noticed that the validation is skipping any directory... Just looking at files in the current directory
remote: ##################################################
remote: ###### Spring Cloud Config Validator 1.1.0 #######
remote: ##################################################
remote: Validating new branch... HHHEEEERRREEE
remote: Processing commit=48414f981d5fb044fcd19b6518d11b9683407016 ref=refs/heads/develop
remote: Processing file config_msaas_test_01-e2e.yml to be saved at /tmp/48414f981d5fb044fcd19b6518d11b9683407016
remote: Processing file config_msaas_test_01-prd.yml to be saved at /tmp/48414f981d5fb044fcd19b6518d11b9683407016
remote: Processing file config_msaas_test_01-dev.yml to be saved at /tmp/48414f981d5fb044fcd19b6518d11b9683407016
remote: Processing file idps/idps-config.sh to be saved at /tmp/48414f981d5fb044fcd19b6518d11b9683407016
remote: Verifying if the DIR exists: /tmp/48414f981d5fb044fcd19b6518d11b9683407016/idps
remote: CREATING DIR FOR CONTEXT: /tmp/48414f981d5fb044fcd19b6518d11b9683407016/idps
remote: Processing file idps/idps.yaml to be saved at /tmp/48414f981d5fb044fcd19b6518d11b9683407016
remote: Verifying if the DIR exists: /tmp/48414f981d5fb044fcd19b6518d11b9683407016/idps
remote: Processing file config_msaas_test_01.yml to be saved at /tmp/48414f981d5fb044fcd19b6518d11b9683407016
remote: Processing file config_msaas_test_01-prf.yml to be saved at /tmp/48414f981d5fb044fcd19b6518d11b9683407016
remote: Processing file idps/common.sh to be saved at /tmp/48414f981d5fb044fcd19b6518d11b9683407016
remote: Verifying if the DIR exists: /tmp/48414f981d5fb044fcd19b6518d11b9683407016/idps
remote: Processing file application.yml to be saved at /tmp/48414f981d5fb044fcd19b6518d11b9683407016
echo ""
remote: Processing file config_msaas_test_01-qal.yml to be saved at /tmp/48414f981d5fb044fcd19b6518d11b9683407016
remote: Processing file README.md to be saved at /tmp/48414f981d5fb044fcd19b6518d11b9683407016
remote: => Validating SHA 48414f981d5fb044fcd19b6518d11b9683407016
remote: Looking for files matching  ['*.json', '*.yaml', '*.yml', '*.properties']
remote: (v) File config_msaas_test_01-prd.yml is valid!
echo "Copy the current validator script to the data container"
remote: (v) File config_msaas_test_01-e2e.yml is valid!
remote: (v) File config_msaas_test_01-qal.yml is valid!
remote: (v) File config_msaas_test_01.yml is valid!
remote: (v) File application.yml is valid!
remote: (v) File config_msaas_test_01-dev.yml is valid!
remote: (v) File config_msaas_test_01-prf.yml is valid!

marcellodesales added a commit that referenced this issue Apr 26, 2019
@marcellodesales
Issue #2: Dockerfile: install of dependencies in Docker
8dfb934 
The Dockerfile was incorrectly setting the list of
dependencies. It should be from the requirements.txt

This time the image is correctly built with the
dependencies, if new ones are added.
marcellodesales added a commit that referenced this issue Apr 26, 2019
@marcellodesales
Issue #2: requirements.txt: adding dependency to glob2
c0792f7 
In a preliminary test, the glob does NOT look at recursive
directories when doing search.

https://github.com/miracle2k/python-glob2/#recursive-glob

Using the documented approach: "**/*.json" would be the
recursive way.

***** TEST ****

Adding a dir "idps/idps.sh" it did not get listed.

remote: ##################################################
remote: ###### Spring Cloud Config Validator 1.1.0 #######
remote: ##################################################
remote: Validating new branch... HHHEEEERRREEE
remote: Processing commit=48414f981d5fb044fcd19b6518d11b9683407016 ref=refs/heads/develop
remote: Processing file config_msaas_test_01-e2e.yml to be saved at /tmp/48414f981d5fb044fcd19b6518d11b9683407016
remote: Processing file config_msaas_test_01-prd.yml to be saved at /tmp/48414f981d5fb044fcd19b6518d11b9683407016
remote: Processing file config_msaas_test_01-dev.yml to be saved at /tmp/48414f981d5fb044fcd19b6518d11b9683407016
remote: Processing file idps/idps-config.sh to be saved at /tmp/48414f981d5fb044fcd19b6518d11b9683407016
remote: Verifying if the DIR exists: /tmp/48414f981d5fb044fcd19b6518d11b9683407016/idps
remote: CREATING DIR FOR CONTEXT: /tmp/48414f981d5fb044fcd19b6518d11b9683407016/idps
remote: Processing file idps/idps.yaml to be saved at /tmp/48414f981d5fb044fcd19b6518d11b9683407016
remote: Verifying if the DIR exists: /tmp/48414f981d5fb044fcd19b6518d11b9683407016/idps
remote: Processing file config_msaas_test_01.yml to be saved at /tmp/48414f981d5fb044fcd19b6518d11b9683407016
remote: Processing file config_msaas_test_01-prf.yml to be saved at /tmp/48414f981d5fb044fcd19b6518d11b9683407016
remote: Processing file idps/common.sh to be saved at /tmp/48414f981d5fb044fcd19b6518d11b9683407016
remote: Verifying if the DIR exists: /tmp/48414f981d5fb044fcd19b6518d11b9683407016/idps
remote: Processing file application.yml to be saved at /tmp/48414f981d5fb044fcd19b6518d11b9683407016
echo ""
remote: Processing file config_msaas_test_01-qal.yml to be saved at /tmp/48414f981d5fb044fcd19b6518d11b9683407016
remote: Processing file README.md to be saved at /tmp/48414f981d5fb044fcd19b6518d11b9683407016
remote: => Validating SHA 48414f981d5fb044fcd19b6518d11b9683407016
remote: Looking for files matching  ['*.json', '*.yaml', '*.yml', '*.properties']
remote: (v) File config_msaas_test_01-prd.yml is valid!
echo "Copy the current validator script to the data container"
remote: (v) File config_msaas_test_01-e2e.yml is valid!
remote: (v) File config_msaas_test_01-qal.yml is valid!
remote: (v) File config_msaas_test_01.yml is valid!
remote: (v) File application.yml is valid!
remote: (v) File config_msaas_test_01-dev.yml is valid!
remote: (v) File config_msaas_test_01-prf.yml is valid!
marcellodesales added a commit that referenced this issue Apr 26, 2019
@marcellodesales
Issue #2: Adding docker-compose.yaml to simplify
6631914 
Creating the docker image with proper name and
version. This will improve the local setup and
testing of the packages.
@marcellodesales
Copy link
Member

  • Solution
GIT_SSH_COMMAND="ssh -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no -p 52311 -i /Users/mdesales/dev/github/public/intuit/intuit-spring-cloud-config-validator/id_rsa_from_github_simulator_server" git push test develop -f
Warning: Permanently added '[172.28.110.65]:52311' (ECDSA) to the list of known hosts.
Enumerating objects: 7, done.
Counting objects: 100% (7/7), done.
Delta compression using up to 8 threads
Compressing objects: 100% (4/4), done.
Writing objects: 100% (4/4), 358 bytes | 358.00 KiB/s, done.
Total 4 (delta 3), reused 0 (delta 0)
remote: ##################################################
remote: ###### Spring Cloud Config Validator 1.1.1 #######
remote: ##################################################
remote: Validating new branch...
remote: Processing commit=a67275c202a8d2d070e3cf19fe135815a4ad110b ref=refs/heads/develop
remote: => Validating SHA a67275c202a8d2d070e3cf19fe135815a4ad110b
remote: Filtering Spring Cloud Config Server's files:  ['**/*.json', '**/*.yaml', '**/*.yml', '**/*.properties']
remote: (v) File config_msaas_test_01-prd.yml is valid!
remote: (v) File config_msaas_test_01-qal.yml is valid!
remote: (v) File config_msaas_test_01.yml is valid!
remote: (v) File config_msaas_test_01-prf.yml is valid!
remote: (x) File idps/idps.yaml is invalid: [2:33: syntax error: mapping values are not allowed here]
remote: (v) File application.yml is valid!
remote: (v) File config_msaas_test_01-e2e.yml is valid!
remote: (x) File config_msaas_test_01-dev.yml is invalid: [13:4: syntax error: mapping values are not allowed here]```

marcellodesales added a commit that referenced this issue Apr 26, 2019
@marcellodesales
Issue #2: Adding docker-compose.yaml to simplify
3452639 
Creating the docker image with proper name and
version. This will improve the local setup and
testing of the packages.
marcellodesales added a commit that referenced this issue Apr 26, 2019
@marcellodesales
Issue #2: Showing the filters for search of files
52c89ae
marcellodesales added a commit that referenced this issue Apr 26, 2019
@marcellodesales
Issue #2: Showing the list of filtered files
0d15173
@marcellodesales
Copy link
Member

Fixed on PR #3

@marcellodesales
Copy link
Member

@hchemanchula Thank u for the report... Will release a new version...

@marcellodesales marcellodesales added this to the v1.2.0 milestone Apr 26, 2019
@hchemanchula
Copy link
Author

@marcellodesales thank you for looking into it. Was there a docker image created with the updated source code already?

@marcellodesales
Copy link
Member

@hchemanchula Yes, any time there's a release...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcellodesales marcellodesales

Labels
bug
Projects
None yet
Milestone
v1.2.0
Development

No branches or pull requests
2 participants
@marcellodesales @hchemanchula