Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/issue 2/multiple directories in repository #3

Merged

Conversation

marcellodesales
Copy link
Member

@marcellodesales marcellodesales commented Apr 26, 2019

Multiple directories validation

Solution Logs

  • Created a repo with files and a directory called idps/idps.yaml
  • Pushed and got the proper validation
GIT_SSH_COMMAND="ssh -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no -p 52311 -i /Users/mdesales/dev/github/public/intuit/intuit-spring-cloud-config-validator/id_rsa_from_github_simulator_server" git push test develop -f
Warning: Permanently added '[172.28.110.65]:52311' (ECDSA) to the list of known hosts.
Enumerating objects: 7, done.
Counting objects: 100% (7/7), done.
Delta compression using up to 8 threads
Compressing objects: 100% (4/4), done.
Writing objects: 100% (4/4), 358 bytes | 358.00 KiB/s, done.
Total 4 (delta 3), reused 0 (delta 0)
remote: ##################################################
remote: ###### Spring Cloud Config Validator 1.1.1 #######
remote: ##################################################
remote: Validating new branch...
remote: Processing commit=a67275c202a8d2d070e3cf19fe135815a4ad110b ref=refs/heads/develop
remote: => Validating SHA a67275c202a8d2d070e3cf19fe135815a4ad110b
remote: Filtering Spring Cloud Config Server's files:  ['**/*.json', '**/*.yaml', '**/*.yml', '**/*.properties']
remote: (v) File config_msaas_test_01-prd.yml is valid!
remote: (v) File config_msaas_test_01-qal.yml is valid!
remote: (v) File config_msaas_test_01.yml is valid!
remote: (v) File config_msaas_test_01-prf.yml is valid!
remote: (x) File idps/idps.yaml is invalid: [2:33: syntax error: mapping values are not allowed here]
remote: (v) File application.yml is valid!
remote: (v) File config_msaas_test_01-e2e.yml is valid!
remote: (x) File config_msaas_test_01-dev.yml is invalid: [13:4: syntax error: mapping values are not allowed here]

The Dockerfile was incorrectly setting the list of
dependencies. It should be from the requirements.txt

This time the image is correctly built with the
dependencies, if new ones are added.
In a preliminary test, the glob does NOT look at recursive
directories when doing search.

https://github.com/miracle2k/python-glob2/#recursive-glob

Using the documented approach: "**/*.json" would be the
recursive way.

***** TEST ****

Adding a dir "idps/idps.sh" it did not get listed.

remote: ##################################################
remote: ###### Spring Cloud Config Validator 1.1.0 #######
remote: ##################################################
remote: Validating new branch... HHHEEEERRREEE
remote: Processing commit=48414f981d5fb044fcd19b6518d11b9683407016 ref=refs/heads/develop
remote: Processing file config_msaas_test_01-e2e.yml to be saved at /tmp/48414f981d5fb044fcd19b6518d11b9683407016
remote: Processing file config_msaas_test_01-prd.yml to be saved at /tmp/48414f981d5fb044fcd19b6518d11b9683407016
remote: Processing file config_msaas_test_01-dev.yml to be saved at /tmp/48414f981d5fb044fcd19b6518d11b9683407016
remote: Processing file idps/idps-config.sh to be saved at /tmp/48414f981d5fb044fcd19b6518d11b9683407016
remote: Verifying if the DIR exists: /tmp/48414f981d5fb044fcd19b6518d11b9683407016/idps
remote: CREATING DIR FOR CONTEXT: /tmp/48414f981d5fb044fcd19b6518d11b9683407016/idps
remote: Processing file idps/idps.yaml to be saved at /tmp/48414f981d5fb044fcd19b6518d11b9683407016
remote: Verifying if the DIR exists: /tmp/48414f981d5fb044fcd19b6518d11b9683407016/idps
remote: Processing file config_msaas_test_01.yml to be saved at /tmp/48414f981d5fb044fcd19b6518d11b9683407016
remote: Processing file config_msaas_test_01-prf.yml to be saved at /tmp/48414f981d5fb044fcd19b6518d11b9683407016
remote: Processing file idps/common.sh to be saved at /tmp/48414f981d5fb044fcd19b6518d11b9683407016
remote: Verifying if the DIR exists: /tmp/48414f981d5fb044fcd19b6518d11b9683407016/idps
remote: Processing file application.yml to be saved at /tmp/48414f981d5fb044fcd19b6518d11b9683407016
echo ""
remote: Processing file config_msaas_test_01-qal.yml to be saved at /tmp/48414f981d5fb044fcd19b6518d11b9683407016
remote: Processing file README.md to be saved at /tmp/48414f981d5fb044fcd19b6518d11b9683407016
remote: => Validating SHA 48414f981d5fb044fcd19b6518d11b9683407016
remote: Looking for files matching  ['*.json', '*.yaml', '*.yml', '*.properties']
remote: (v) File config_msaas_test_01-prd.yml is valid!
echo "Copy the current validator script to the data container"
remote: (v) File config_msaas_test_01-e2e.yml is valid!
remote: (v) File config_msaas_test_01-qal.yml is valid!
remote: (v) File config_msaas_test_01.yml is valid!
remote: (v) File application.yml is valid!
remote: (v) File config_msaas_test_01-dev.yml is valid!
remote: (v) File config_msaas_test_01-prf.yml is valid!
Creating the docker image with proper name and
version. This will improve the local setup and
testing of the packages.
@marcellodesales marcellodesales force-pushed the bugfix/issue-2/multiple-directories-in-repository branch from 6631914 to 0d15173 Compare April 26, 2019 05:40
@marcellodesales marcellodesales merged commit 2a5b565 into master Apr 26, 2019
@marcellodesales marcellodesales deleted the bugfix/issue-2/multiple-directories-in-repository branch April 26, 2019 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant