Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/eslint formatting #38

Merged
merged 4 commits into from
Oct 5, 2019

Conversation

mcrosby114
Copy link
Contributor

Addresses the all the eslint errors except the "no-undef" from #32.

@mcrosby114
Copy link
Contributor Author

mcrosby114 commented Oct 4, 2019

@abisalehalliprasan can we upgrade the version of node to something greater than 6, like version 8? Seeing there's an issue with the JS engine not recognizing Object.entries() (https://travis-ci.org/intuit/oauth-jsclient/jobs/593613545#L292).

This shows how it's incompatible with the current version of node: https://node.green/#ES2017-features-Object-static-methods-Object-entries

@abisalehalliprasan
Copy link
Collaborator

@abisalehalliprasan can we upgrade the version of node to something greater than 6, like version 8? Seeing there's an issue with the JS engine not recognizing Object.entries() (https://travis-ci.org/intuit/oauth-jsclient/jobs/593613545#L292).

This shows how it's incompatible with the current version of node: https://node.green/#ES2017-features-Object-static-methods-Object-entries

Yeah, I think it should be fine. I can bump a version up and release, following the sem version.

Looks Good @mcrosby114 👍 🙌

@abisalehalliprasan abisalehalliprasan merged commit ad56e5f into intuit:develop Oct 5, 2019
@abisalehalliprasan
Copy link
Collaborator

🚀 PR was released in v2.0.0 hacktoberfest

@mcrosby114
Copy link
Contributor Author

#38 (comment) 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants