Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed tests requirements from setup.py. #7

Merged
merged 1 commit into from Feb 28, 2019

Conversation

felixxm
Copy link
Contributor

@felixxm felixxm commented Feb 21, 2019

IMO tests requirements should be removed from the list of packages required for using intuit-oauth, because keeping them in install_requires causes conflicts with local requirements.

@coveralls
Copy link

coveralls commented Feb 21, 2019

Pull Request Test Coverage Report for Build 46

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.457%

Totals Coverage Status
Change from base Build 44: 0.0%
Covered Lines: 182
Relevant Lines: 199

💛 - Coveralls

2 similar comments
@coveralls
Copy link

Pull Request Test Coverage Report for Build 46

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.457%

Totals Coverage Status
Change from base Build 44: 0.0%
Covered Lines: 182
Relevant Lines: 199

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 46

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.457%

Totals Coverage Status
Change from base Build 44: 0.0%
Covered Lines: 182
Relevant Lines: 199

💛 - Coveralls

@felixxm
Copy link
Contributor Author

felixxm commented Feb 28, 2019

@hlu2 @nbhambhani Can you take a look?

@diana-derose
Copy link

@felixxm - We'll take a look at this, thanks for the PR.

@felixxm
Copy link
Contributor Author

felixxm commented Feb 28, 2019

@diana-derose Thanks! 👍 Let me know if I can help.

@hlu2 hlu2 merged commit 8050d40 into intuit:master Feb 28, 2019
@felixxm felixxm deleted the requirements-conflicts branch March 1, 2019 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants