Corrected typos and unused variables

intuit · Oct 3, 2016 · 6d891e5 · 6d891e5
1 parent ea41cdf
commit 6d891e5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/...-test/src/main/java/com/intuit/wasabi/tests/service/EmptyBucketGetUserAssignmentTest.java b/...-test/src/main/java/com/intuit/wasabi/tests/service/EmptyBucketGetUserAssignmentTest.java
@@ -45,7 +45,6 @@ public class EmptyBucketGetUserAssignmentTest extends TestBase {
 
     private Experiment experiment;
     private List<Bucket> buckets = new ArrayList<>();
-    private User specialUser = UserFactory.createUser("SpecialForBucketTest");
     private User specialUser2 = UserFactory.createUser("Special2ForBucketTest");
 
     /**
@@ -84,10 +83,10 @@ public void t_GetUserAssignmentEmptyBucket() {
         Assignment putAssignmentFor2 = putAssignment(experiment, assignment, specialUser2);
         assertEqualModelItems(putAssignmentFor2, assignment, new DefaultNameInclusionStrategy("assignment"));
 
-       // Empty bucke to which use is assigned
+       // Empty bucket to which use is assigned
        List<Bucket> emptyBucket = new ArrayList<>();
        emptyBucket.add(buckets.get(0));
-       emptyBucket = putBucketsState(emptyBucket, Constants.BUCKET_STATE_EMPTY);
+       putBucketsState(emptyBucket, Constants.BUCKET_STATE_EMPTY);
 
        // Get assignment after emptying bucket
        Assignment getAssignmentAfterEmpty = getAssignment(experiment, specialUser2);

diff --git a/...n/java/com/intuit/wasabi/tests/service/EmptyBucketGetUserAssignmentToEmptyBucketTest.java b/...n/java/com/intuit/wasabi/tests/service/EmptyBucketGetUserAssignmentToEmptyBucketTest.java
@@ -50,7 +50,7 @@ public EmptyBucketGetUserAssignmentToEmptyBucketTest() {
      * Test scenario where user is being reassigned from empty bucket to another empty bucket
      */
     @Test(dependsOnGroups = {"ping"})
-    public void t_AddUserToExperimentWith2BucektsAndEmptyBucketBothAndReassignToAnotherEmptyBucket() {
+    public void t_AddUserToExperimentWith2BucketsAndEmptyBucketBothAndReassignToAnotherEmptyBucket() {
         Experiment exp = postExperiment(experiment);
         Assert.assertNotNull(exp.creationTime, "Experiment creation failed.");
         Assert.assertNotNull(exp.modificationTime, "Experiment creation failed (No modificationTime).");
@@ -76,7 +76,7 @@ public void t_AddUserToExperimentWith2BucektsAndEmptyBucketBothAndReassignToAnot
        List<Bucket> emptyBucket = new ArrayList<>();
        emptyBucket.add(buckets.get(0));
        emptyBucket.add(buckets.get(1));
-       emptyBucket = putBucketsState(emptyBucket, Constants.BUCKET_STATE_EMPTY);
+       putBucketsState(emptyBucket, Constants.BUCKET_STATE_EMPTY);
 
        // There should be no bucket available for user
        Assignment getAssignmentAfterAllEmptyBuckets = getAssignment(experiment, specialUser);