Use simpler value for example global transitions variable. #215

anselmh · 2016-10-25T06:22:27Z

This addresses #214.

csshugs · 2016-10-25T06:32:16Z

settings/_example.settings.global.scss

@@ -6,4 +6,4 @@

 // Standardise some UI treatments.
 $global-radius: 3px !default;
-$global-transition: (1/3) + s !default;
+$global-transition: 300ms !default;


I would like to enhance it to like what @fuhlig suggested here in his simple example:

$global-transition: all 0.3s ease;

I think when we just set a duration as a value, the variable should be named $global-transition-duration instead.

This addresses #214.

csshugs

👍 LGTM

Outdated, all changes have been fixed.

anselmh added the enhancement label Oct 25, 2016

anselmh assigned nenadjelovac, florianbouvot and csshugs Oct 25, 2016

csshugs previously requested changes Oct 25, 2016

View reviewed changes

Use simpler value for example global transitions variable.

83be6b4

This addresses #214.

anselmh force-pushed the tkt-0214 branch from b5a53cb to 83be6b4 Compare October 25, 2016 06:40

csshugs approved these changes Oct 25, 2016

View reviewed changes

anselmh merged commit 0097577 into develop Oct 25, 2016

anselmh deleted the tkt-0214 branch October 25, 2016 06:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use simpler value for example global transitions variable. #215

Use simpler value for example global transitions variable. #215

anselmh commented Oct 25, 2016

csshugs Oct 25, 2016

csshugs left a comment

Use simpler value for example global transitions variable. #215

Use simpler value for example global transitions variable. #215

Conversation

anselmh commented Oct 25, 2016

csshugs Oct 25, 2016

Choose a reason for hiding this comment

csshugs left a comment

Choose a reason for hiding this comment