Corrected file path in README.md #348
Conversation
olivertappin
force-pushed
the
tkt-0347
branch
from
b9cce9f
to
724f12a
Compare
olivertappin
force-pushed
the
tkt-0347
branch
from
724f12a
to
cc46176
Compare
|
Thanks for the contribution, and for finding the mistake, but there is a long running issue for this type of small correction (#21). I think the best would be to point this to that issue instead, |
CHANGELOG.md
Outdated
| @@ -15,6 +15,7 @@ | |||
| ### Fixes | |||
| - Fix `o-layout--stretch` in conjunction with `o-layout--center`, `o-layout--right` and `o-layout--left`. [[#293](https://github.com/inuitcss/inuitcss/issues/293)] | |||
| - Update to Sass’ `@else if` syntax according to current spec. [[#331](https://github.com/inuitcss/inuitcss/issues/331)] | |||
| - Corrected filename for _objects.table.scss in README.md example. [[#347](https://github.com/inuitcss/inuitcss/issues/347)] | |||
There was a problem hiding this comment.
Please use imperative instead of past tense:
- Correct filename [...]
|
Comment addressed @csshugs. And @herzinger that's fine. Does this make this PR invalid, or is your reference to that issue enough to get this through? |
There was a problem hiding this comment.
@olivertappin No, it's fine, thank you for the change. Let's not be too pedantic about it.
One small thing for the future: Try to stick to our commit message conventions, so we get an even better paper trail when logging commits. But as I said, let's not be too pedantic about.
Thanks again for pointing out and fixing this error!
No description provided.