Fix importing update readme #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lazaroreyesjobsity
previously approved these changes
Dec 13, 2018
monksy
reviewed
Dec 13, 2018
README.md
Outdated
| The following dependencies are required for robotframework-pykafka. | ||
|
|
||
| ``` | ||
| pip install [-U] [--user] \ |
There was a problem hiding this comment.
This should be pip install -r requirements.txt
The dependencies with python are typically deployed that way.
README.md
Outdated
| ``` | ||
| pip install [-U --user] robotframework robotframework-pykafka | ||
| pip install [-U ] [--user] robotframework-pykafka |
There was a problem hiding this comment.
Or adding "robotframework-python = 0.1.0` to your requirements file.
invadergir
dismissed stale reviews from nexcax and lazaroreyesjobsity
via
33e7b71
monksy
approved these changes
Dec 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some updates to make importing easier, and updates to the README. Please try it out...