Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add refresh buttons for new position and position details #641

Draft
wants to merge 17 commits into
base: dev
Choose a base branch
from
Draft

add refresh buttons for new position and position details #641

wants to merge 17 commits into from

Conversation

p6te
Copy link
Collaborator

@p6te p6te commented Mar 26, 2024 •
edited
Loading

add refresh buttons for new position and position details.

image

image

PR will be finished after merge #662

wojciech-cichocki
wojciech-cichocki requested changes Mar 26, 2024
View reviewed changes
Copy link
Member

@wojciech-cichocki wojciech-cichocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refresh on position details is not working correctly. Every time I click the refresh button on the "position details," my unclaimed fees change to 0, even though there are accumulated fees in this position

@wojciech-cichocki
Copy link
Member

Refresh on position details is not working correctly. Every time I click the refresh button on the "position details," my unclaimed fees change to 0, even though there are accumulated fees in this position

Additionally, the liquidity chart should also be redrawn

wojciech-cichocki
wojciech-cichocki reviewed Mar 29, 2024
View reviewed changes
Copy link
Member

@wojciech-cichocki wojciech-cichocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested that refreshing closed position and redirecting to the position list works correctly

wojciech-cichocki
wojciech-cichocki requested changes Mar 29, 2024
View reviewed changes
Copy link
Member

@wojciech-cichocki wojciech-cichocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indexes of selected ticks should not be reset upon refreshing on the "add liquidity" view

wojciech-cichocki
wojciech-cichocki requested changes Apr 5, 2024
View reviewed changes
Copy link
Member

@wojciech-cichocki wojciech-cichocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to include a global price update in the refresh button and align this PR with the master

@p6te p6te marked this pull request as draft April 12, 2024 16:56
@github-actions GitHub Actions
Copy link

This pull request has been deployed to Vercel.

Latest commit: 5b55792
✅ Preview: https://webapp-cr288xf19-invariantlabs.vercel.app
🔍 Inspect: https://vercel.com/invariantlabs/webapp/HfKvJvpCZKxuPQHSWZ13viWBgEjc

View Workflow Logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wojciech-cichocki wojciech-cichocki wojciech-cichocki requested changes

Assignees
No one assigned
Labels
deployed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@p6te @wojciech-cichocki