New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support item templates for autocomplete and refactor ref-field #230
Merged
jmartinm
merged 2 commits into
inveniosoftware-contrib:master
from
harunurhan:templating-things
Mar 29, 2017
Merged
support item templates for autocomplete and refactor ref-field #230
jmartinm
merged 2 commits into
inveniosoftware-contrib:master
from
harunurhan:templating-things
Mar 29, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harunurhan
force-pushed
the
templating-things
branch
from
March 28, 2017 13:03
cf52b8c
to
460999f
Compare
harunurhan
force-pushed
the
templating-things
branch
from
March 29, 2017 09:19
460999f
to
0c31b41
Compare
harunurhan
changed the title
support item templates for autocomplete fields
support item templates for autocomplete and refactor ref-field
Mar 29, 2017
Looks good to me. |
@jmartinm I will update it and let you know when it's ready to merge |
LGTM! |
harunurhan
force-pushed
the
templating-things
branch
from
March 29, 2017 13:31
0c31b41
to
a494e3f
Compare
@jmartinm cleaned up config and example app, ready to merge. |
harunurhan
force-pushed
the
templating-things
branch
from
March 29, 2017 14:05
a494e3f
to
2578e59
Compare
* Uses <template> instead of dynamic module and component compilation. * Fixes inveniosoftware-contrib#188
jmartinm
approved these changes
Mar 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so this how it looks you can have a look (still WIP though), this is the cleanest way that I can think of, we can also use this this
templates
input for$ref
fields in order to avoid dynamic definition and component loading.UPDATE:
I also refactored the
ref-field
to use<template>
, see second commit.TODO: