Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support item templates for autocomplete and refactor ref-field #230

Merged
merged 2 commits into from Mar 29, 2017

Conversation

harunurhan
Copy link
Contributor

@harunurhan harunurhan commented Mar 28, 2017

so this how it looks you can have a look (still WIP though), this is the cleanest way that I can think of, we can also use this this templates input for $ref fields in order to avoid dynamic definition and component loading.

UPDATE:

I also refactored the ref-field to use <template>, see second commit.

TODO:

  • clean up example before the merging.

@coveralls
Copy link

coveralls commented Mar 28, 2017

Coverage Status

Coverage increased (+0.08%) to 79.961% when pulling 460999f on harunurhan:templating-things into 77b3d80 on inveniosoftware-contrib:master.

@harunurhan harunurhan changed the title support item templates for autocomplete fields support item templates for autocomplete and refactor ref-field Mar 29, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+1.3%) to 81.199% when pulling 0c31b41 on harunurhan:templating-things into 77b3d80 on inveniosoftware-contrib:master.

@jmartinm
Copy link
Contributor

Looks good to me.

@harunurhan
Copy link
Contributor Author

@jmartinm I will update it and let you know when it's ready to merge

@zzacharo
Copy link
Collaborator

LGTM!

@harunurhan
Copy link
Contributor Author

@jmartinm cleaned up config and example app, ready to merge.

* Uses <template>  instead of dynamic module and component compilation.

* Fixes inveniosoftware-contrib#188
@coveralls
Copy link

coveralls commented Mar 29, 2017

Coverage Status

Coverage increased (+1.3%) to 81.18% when pulling 2578e59 on harunurhan:templating-things into 77b3d80 on inveniosoftware-contrib:master.

@jmartinm jmartinm merged commit 27d965d into inveniosoftware-contrib:master Mar 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants