Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

add npm link documentation #231

Merged

Conversation

harunurhan
Copy link
Contributor

Today @zzacharo and I realized that this is needed 馃槃

@zzacharo
Copy link
Collaborator

zzacharo commented Mar 29, 2017

馃憤 Perfect !

@coveralls
Copy link

coveralls commented Mar 29, 2017

Coverage Status

Coverage remained the same at 79.881% when pulling 22782b2 on harunurhan:npm-link-docs into 77b3d80 on inveniosoftware-contrib:master.

npm run build

# copy package.json to dist
npm run copy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was this for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is for copying LICENSE and package.json to dist so that we release only dist folder.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And why is it needed to work with npm link ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package.json is needed for linking inside dist folder. Otherwise, it will link from the nearest folder that includes one.

@zzacharo
Copy link
Collaborator

@jmartinm package.json is needed for linking inside dist folder. Otherwise, it will link from the nearest folder that includes one! @harunurhan right?

@harunurhan
Copy link
Contributor Author

Yes, the process should be same as publishing, otherwise npm looks for a package.json in parent directories and links not only dist, but a lot of other stuff.

@harunurhan harunurhan removed the WIP label Apr 4, 2017
@harunurhan harunurhan merged commit 264a15a into inveniosoftware-contrib:master Apr 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants