-
Notifications
You must be signed in to change notification settings - Fork 4
Conversation
Now that #35 is merged, can you please rebase against latest master and amend |
* Refactors the restful api in order to use Flask-Restful. * Improves Exception management. * Modifies slightly the GET claims response by removing the json_list wrapping dictionary. Signed-off-by: Jose Benito Gonzalez Lopez <jose.benito.gonzalez@cern.ch>
* Renames `datetime` (inside claim) with `created` the JSON schema, examples and RFC. Signed-off-by: Jose Benito Gonzalez Lopez <jose.benito.gonzalez@cern.ch>
178d35e
to
b3c661c
Compare
@tiborsimko rebase and re-pushed done. |
@@ -1,38 +0,0 @@ | |||
# -*- coding: utf-8 -*- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following up the removal of decorators.py
, please also update docs/api.py
, otherwise one gets:
/code/docs/api.rst:57: WARNING: autodoc: failed to import module 'claimstore.core.decorators'; the following exception was raised:
Traceback (most recent call last):
File "/usr/local/lib/python3.4/site-packages/sphinx/ext/autodoc.py", line 385, in import_object
__import__(self.modname)
ImportError: bad magic number in 'claimstore.core.decorators': b'\x03\xf3\r\n'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed. Thanks!
* Enriches the resource GET claims by adding a by-argument-search. Now one can search by any combination of: claimant, predicate, certainty, human, actor, role, since, from, object/subject or type/value. (addresses inveniosoftware#23) * Refactores the database model: `uid` columns are now simply `id`, certainty became a float number and human is a 0/1 value. Signed-off-by: Jose Benito Gonzalez Lopez <jose.benito.gonzalez@cern.ch>
* Explains how to do requests through python. * Lists all arguments that can be used in GET claims. (addresses inveniosoftware#23) Signed-off-by: Jose Benito Gonzalez Lopez <jose.benito.gonzalez@cern.ch>
* Tests all possible queries for GET claims. (closes inveniosoftware#23) Signed-off-by: Jose Benito Gonzalez Lopez <jose.benito.gonzalez@cern.ch>
b3c661c
to
a0334bc
Compare
@tiborsimko Thanks for the comments. Changed and pushed. |
Docs are now OK, but I still see SQL exception mentioned above #34 (comment). Shall we address this later? |
Enables to query for claims using many different parameters.