Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: simplify doctest execution #97

Closed
tiborsimko opened this issue Feb 22, 2017 · 0 comments · Fixed by #98
Closed

tests: simplify doctest execution #97

tiborsimko opened this issue Feb 22, 2017 · 0 comments · Fixed by #98
Assignees
@tiborsimko
Milestone
v1.0.0

Comments

@tiborsimko
Copy link
Member

In run-tests.sh, the sphinx for doctests is invoked after pytest run:

$ tail -3 ./\{\{\ cookiecutter.project_shortname\ \}\}/run-tests.sh 
sphinx-build -qnNW docs docs/_build/html && \
python setup.py test && \
sphinx-build -qnNW -b doctest docs docs/_build/doctest

This led to problems observed on Travis CI with the second sphinx-build run due to "disappearing" dependencies.

A solution that worked for invenio-marc21 (see inveniosoftware/invenio-marc21#49 (comment) ) was to run doctest execution in pytest. This both solved development requirement Travis CI build failures and simplified test suite execution.

It would be good to propagate similar solution to all Invenio packages.
@tiborsimko tiborsimko added this to the v1.0.0 milestone Feb 22, 2017
@tiborsimko tiborsimko self-assigned this Feb 22, 2017
tiborsimko added a commit to tiborsimko/cookiecutter-invenio-module that referenced this issue Feb 22, 2017
@tiborsimko
tests: doctext execution simplification
85fed05 
* Performs doctest execution within the initial pytest run, simplifying test
  suite execution and solving "disappearing development requirements" problem
  that was sometimes observed with development-level dependencies. (closes inveniosoftware#97)

Signed-off-by: Tibor Simko <tibor.simko@cern.ch>
@tiborsimko tiborsimko mentioned this issue Feb 22, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tiborsimko tiborsimko

Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

tests: doctext execution simplification tiborsimko/cookiecutter-invenio-module
2 participants
@tiborsimko @lnielsen