dictdiffer: fix for empty list instructions #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jirikuncar
force-pushed
the
no-empty-lists
branch
2 times, most recently
from
32d4249
to
4006fb3
Compare
Signed-off-by: Jiri Kuncar <jiri.kuncar@cern.ch>
Signed-off-by: Jiri Kuncar <jiri.kuncar@cern.ch>
* Addresses an issue when `reversed` iterator was evaluated as `True` causing empty instruction set to appear. (closes inveniosoftware#30) Signed-off-by: Jiri Kuncar <jiri.kuncar@cern.ch>
jirikuncar
force-pushed
the
no-empty-lists
branch
from
4006fb3
to
2d65235
Compare
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reversediterator was evaluated asTruecausing empty instruction set to appear. (closesdiff()producing diffs with empty list removals #30)Signed-off-by: Jiri Kuncar jiri.kuncar@cern.ch