Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

searchComponents: add namespace #151

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

searchComponents: add namespace #151

wants to merge 1 commit into from

Conversation

jrcastro2
Copy link
Contributor

@jrcastro2 jrcastro2 commented Jan 23, 2023 •
edited
Loading

@jrcastro2 jrcastro2 force-pushed the add-namespace-searchapp branch 2 times, most recently from 6cd94cc to c5e73fe Compare January 24, 2023 15:14
jrcastro2
jrcastro2 commented Jan 24, 2023
View reviewed changes
invenio_administration/assets/semantic-ui/js/invenio_administration/src/actions/ActionModal.js
@@ -33,11 +34,11 @@ ActionModal.propTypes = {
children: PropTypes.object,
modalOpen: PropTypes.bool,
resource: PropTypes.object.isRequired,
appName: PropTypes.string,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO appName should be required to avoid having different admin views that can be potentially overriden by the same component, if this varabiable is missing. That's why I raise an error (see base.py). I will do the change unless someone has a different opinion

This was referenced Jan 25, 2023
Draft
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Override: improve overridable components
1 participant
@jrcastro2